Issue Details (XML | Word | Printable)

Key: CORE-1271
Type: Bug Bug
Status: Closed Closed
Resolution: Fixed
Priority: Major Major
Assignee: Adriano dos Santos Fernandes
Reporter: Adriano dos Santos Fernandes
Votes: 0
Watchers: 0
Operations

If you were logged in you would be able to see more operations.
Firebird Core

Creation of invalid procedures/triggers allowed

Created: 20/May/07 07:37 AM   Updated: 03/Oct/08 08:33 AM
Component/s: Engine
Affects Version/s: 2.1 Alpha 1
Fix Version/s: 2.1 Beta 1

Time Tracking:
Not Specified

Issue Links:
Relate
 


 Description  « Hide
Dmitry reported that invalid procedures/triggers (with invalid plans, for example) was allowed to be created.
This is a regression of domains in PSQL code.

 All   Comments   Work Log   Change History   Version Control   Subversion Commits      Sort Order: Ascending order - Click to sort in descending order
Pavel Cisar added a comment - 16/Aug/07 01:51 PM
I have trouble to reproduce it with Alpha 1. Could you please provide a reproducible test case?

Adriano dos Santos Fernandes added a comment - 16/Aug/07 02:07 PM
He said:

The problem I have at hands is that CREATE/ALTER no longer cause the object to be compiled/optimized, thus everyone is now allowed to create invalid objects (containing wrong plans, ordering by blobs and other issues) without any warning (we have enough errors ignored by both the DSQL and PAR layers). While I have intentionally made the engine working this way for the restore process, I don't think it's good for the generic practice.

Dmitry Yemanov added a comment - 16/Aug/07 02:42 PM - edited
I don't have Alpha 1 installed to verify the test case, but I think the following script should execute OK for Alpha 1 (what is wrong) and fail for Beta 1 (what is correct):

create procedure p returns (out int)
as
begin
  for select rdb$relation_id
    from rdb$relations
    order by rdb$description
    into :out
  do
    suspend;
end

commit;

Philippe Makowski added a comment - 03/Oct/08 08:33 AM
Q/A tested ok