Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creation of invalid procedures/triggers allowed [CORE1271] #1692

Closed
firebird-automations opened this issue May 20, 2007 · 9 comments
Closed

Comments

@firebird-automations
Copy link
Collaborator

Submitted by: @asfernandes

Is related to QA144

Dmitry reported that invalid procedures/triggers (with invalid plans, for example) was allowed to be created.
This is a regression of domains in PSQL code.

Commits: de7a981

@firebird-automations
Copy link
Collaborator Author

Modified by: @asfernandes

status: Open [ 1 ] => Resolved [ 5 ]

resolution: Fixed [ 1 ]

@firebird-automations
Copy link
Collaborator Author

Modified by: @pcisar

Link: This issue is related to QA144 [ QA144 ]

@firebird-automations
Copy link
Collaborator Author

Commented by: @pcisar

I have trouble to reproduce it with Alpha 1. Could you please provide a reproducible test case?

@firebird-automations
Copy link
Collaborator Author

Commented by: @asfernandes

He said:

The problem I have at hands is that CREATE/ALTER no longer cause the object to be compiled/optimized, thus everyone is now allowed to create invalid objects (containing wrong plans, ordering by blobs and other issues) without any warning (we have enough errors ignored by both the DSQL and PAR layers). While I have intentionally made the engine working this way for the restore process, I don't think it's good for the generic practice.

@firebird-automations
Copy link
Collaborator Author

Commented by: @dyemanov

I don't have Alpha 1 installed to verify the test case, but I think the following script should execute OK for Alpha 1 (what is wrong) and fail for Beta 1 (what is correct):

create procedure p returns (out int)
as
begin
for select rdb$relation_id
from rdb$relations
order by rdb$description
into :out
do
suspend;
end

commit;

@firebird-automations
Copy link
Collaborator Author

Modified by: @pcisar

Workflow: jira [ 12151 ] => Firebird [ 15374 ]

@firebird-automations
Copy link
Collaborator Author

Commented by: @pmakowski

Q/A tested ok

@firebird-automations
Copy link
Collaborator Author

Modified by: @pmakowski

status: Resolved [ 5 ] => Closed [ 6 ]

@firebird-automations
Copy link
Collaborator Author

Modified by: @pavel-zotov

status: Closed [ 6 ] => Closed [ 6 ]

QA Status: Done successfully

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants