Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sometime INET error reported as 0 in firebird.log instead of real error code [CORE1276] #1697

Closed
firebird-automations opened this issue May 22, 2007 · 9 comments

Comments

@firebird-automations
Copy link
Collaborator

Submitted by: @hvlad

inet.cpp have many places in code when we analyse error code not immediate after sockets function call but after following THREAD_ENTER call.
It seems Win API functions called by THREAD_ENTER (WaitForMultipleObjects for example) can reset error code returned by WSAGetLastError.
Solution is to read WSAGetLastError into local variable immediate after socket function call and operate with this variable not calling WSAGetLastError again

Commits: 337749d 0eb6387

@firebird-automations
Copy link
Collaborator Author

Commented by: @hvlad

User report was:

INET/select_wait: select failed, errno =0
SRVR_multi_thread/RECEIVE: error on main_port, shutting down

After it server stop accept new connections but worked well with existing ones

@firebird-automations
Copy link
Collaborator Author

Modified by: @hvlad

environment: User reported WinXP, FB 2.0.1 but i sure it can happen in every FB version on windows => User reported WinXP, FB 2.0.1 SS but i sure it can happen in every FB SS versions on windows

@firebird-automations
Copy link
Collaborator Author

Commented by: @hvlad

Can't verify fix as i can't reproduce the error

@firebird-automations
Copy link
Collaborator Author

Modified by: @hvlad

status: Open [ 1 ] => Resolved [ 5 ]

resolution: Fixed [ 1 ]

Fix Version: 2.1 Beta 1 [ 10141 ]

@firebird-automations
Copy link
Collaborator Author

Modified by: @pcisar

status: Resolved [ 5 ] => Closed [ 6 ]

@firebird-automations
Copy link
Collaborator Author

Modified by: @hvlad

Fix Version: 2.0.2 [ 10130 ]

@firebird-automations
Copy link
Collaborator Author

Modified by: @pcisar

Workflow: jira [ 12171 ] => Firebird [ 15577 ]

@firebird-automations
Copy link
Collaborator Author

Modified by: @pavel-zotov

QA Status: No test

@firebird-automations
Copy link
Collaborator Author

Modified by: @pavel-zotov

status: Closed [ 6 ] => Closed [ 6 ]

QA Status: No test => Cannot be tested

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants