New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Typo in the intl/utils/mapgen4.c [CORE1374] #1792
Comments
Commented by: morgan mo (morgan) There is another typo . 199 /* Small tables print with all comments */ 200 line should be: |
Modified by: @asfernandesstatus: Open [ 1 ] => Resolved [ 5 ] resolution: Fixed [ 1 ] Fix Version: 2.1 Beta 2 [ 10190 ] assignee: Adriano dos Santos Fernandes [ asfernandes ] |
Commented by: @asfernandes Morgan, nobody is using this utility... Are you sure about the line 200? Why it should be changed? |
Commented by: morgan mo (morgan) yes, nobody use it. I just want learn how the mapping table file was created. Through mapgen4.c, only inceased codepoint_conversion.count and the unicode_conversion.count not changed. We know codepoint_conversion.count should be equel to unicode_conversion.count(codepoint_conversion is codepoint-->unicode and unicode_conversion is unicode-->codepoint). So we can change the code as above. I use gb2312.txt to test my modify. Yes , after modified, mapgen4 output the correct result that as same as intl\charsets\cs_gb2312.h |
Modified by: @pcisarstatus: Resolved [ 5 ] => Closed [ 6 ] |
Modified by: @pcisarWorkflow: jira [ 12650 ] => Firebird [ 14233 ] |
Modified by: @pavel-zotovQA Status: No test |
Modified by: @pavel-zotovstatus: Closed [ 6 ] => Closed [ 6 ] QA Status: No test => Cannot be tested |
Submitted by: morgan mo (morgan)
The tool mapgen4 can not generate the correct mapping table file. Check the source file intl/utils/mapgen4.c.
There is typo in it.
237 if (unicode < unicode_conversion.low_point)
238 unicode_conversion.low_point = unicode;
239 if (unicode > unicode_conversion.high_point)
240 codepoint_conversion.high_point = unicode;
the code at 240 line should be:
unicode_conversion.high_point = unicode;
Commits: cc99259 7599b49
The text was updated successfully, but these errors were encountered: