Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small patch for mingw building [CORE1433] #1851

Closed
firebird-automations opened this issue Aug 29, 2007 · 4 comments
Closed

Small patch for mingw building [CORE1433] #1851

firebird-automations opened this issue Aug 29, 2007 · 4 comments

Comments

@firebird-automations
Copy link
Collaborator

Submitted by: @tonal

Index: builds/posix/Makefile.in.boot.gpre

RCS file: /cvsroot/firebird/firebird2/builds/posix/Makefile.in.boot.gpre,v
retrieving revision 1.28
diff -u -r1.28 Makefile.in.boot.gpre
--- builds/posix/Makefile.in.boot.gpre 29 Mar 2007 06:08:47 -0000 1.28
+++ builds/posix/Makefile.in.boot.gpre 29 Aug 2007 19:05:25 -0000
@@ -72,7 +72,7 @@
$(GPRE_BOOT): $(GPREBOOT_Objects)
$(LD) $(LINK_OPTS) $^ -o $@ -L$(LIB) $(LINK_LIBS)
-$(RM) $(GPRE_CURRENT)
- (cd $(@d); $(LN) $(@f) $(notdir $(GPRE_CURRENT)))
+ (cd $(@d); $(LN) $(@f).$(EXEC_EXT) $(notdir $(GPRE_CURRENT)).$(EXEC_EXT))

Index: http://configure.in

RCS file: /cvsroot/firebird/firebird2/configure.in,v
retrieving revision 1.260
diff -u -r1.260 http://configure.in
--- http://configure.in 28 Aug 2007 11:19:00 -0000 1.260
+++ http://configure.in 29 Aug 2007 19:04:30 -0000
@@ -216,6 +216,7 @@
EDITLINE_FLG=N
RAW_DEVICES_FLG=N
SHRLIB_EXT=dll
+ EXEEXT=exe
ICU_PLATFORM=MinGW
service_thread_CS=true
;;

@firebird-automations
Copy link
Collaborator Author

Commented by: @aafemt

The patch is invalid. GPRE_BOOT and GPRE_CURRENT already include EXEC_EXT (see make.defaults). EXEEXT variable is set by autoconf during AC_PROG_CXX test.

@firebird-automations
Copy link
Collaborator Author

Modified by: @aafemt

status: Open [ 1 ] => Resolved [ 5 ]

resolution: Won't Fix [ 2 ]

@firebird-automations
Copy link
Collaborator Author

Modified by: @pcisar

status: Resolved [ 5 ] => Closed [ 6 ]

@firebird-automations
Copy link
Collaborator Author

Modified by: @pcisar

Workflow: jira [ 12912 ] => Firebird [ 15047 ]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant