Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Server crashes with secondary file name > 127 characters [CORE1470] #1887

Closed
firebird-automations opened this issue Sep 19, 2007 · 15 comments
Closed

Comments

@firebird-automations
Copy link
Collaborator

Submitted by: Lukas Petrlik (petrlik)

Assigned to: Claudio Valderrama C. (robocop)

Server crashes when a client attempts to connect to a database whose secondary file name is longer than 127 characters.

Steps to reproduce:

- create a database
- execute 'alter database add file' with a file name > 127 characters
- close the connection and connect again; the server will crash.

Used software: Firebird-2.0.1.12855-1_embed_win32, also crashes with 2.0.0

Cause: Sign extension bug on jrd/pag.cpp:1453 which reads:

    file\_length = p\[1\];  // SCHAR to USHORT

Commits: 667d5e6 65999a3 0519215

@firebird-automations
Copy link
Collaborator Author

Modified by: Claudio Valderrama C. (robocop)

assignee: Claudio Valderrama C. [ robocop ]

@firebird-automations
Copy link
Collaborator Author

Commented by: Claudio Valderrama C. (robocop)

The bug was introduced in the migration of the code from C to C++.
FB1 doesn't have the bug.
Any FB1.5 and newer will typically vanish without any error message (silent crash).

@firebird-automations
Copy link
Collaborator Author

Modified by: Claudio Valderrama C. (robocop)

Version: 2.0.2 [ 10130 ]

Version: 2.1 Beta 1 [ 10141 ]

Version: 2.1 Alpha 1 [ 10150 ]

Version: 1.5.4 [ 10100 ]

Version: 2.0.0 [ 10091 ]

Version: 1.5.3 [ 10028 ]

Version: 1.5.2 [ 10027 ]

timeestimate: 600 [ 600 ]

timeoriginalestimate: 600 [ 600 ]

@firebird-automations
Copy link
Collaborator Author

Commented by: Claudio Valderrama C. (robocop)

Also fixed in the 1.5 branch after 1.5.4.

@firebird-automations
Copy link
Collaborator Author

Modified by: Claudio Valderrama C. (robocop)

status: Open [ 1 ] => Resolved [ 5 ]

resolution: Fixed [ 1 ]

Fix Version: 2.1 Beta 2 [ 10190 ]

@firebird-automations
Copy link
Collaborator Author

Modified by: @dyemanov

summary: Sever crashes with secondary file name > 127 characters => Server crashes with secondary file name > 127 characters

@firebird-automations
Copy link
Collaborator Author

Modified by: @pcisar

Fix Version: 1.5.5 [ 10220 ]

@firebird-automations
Copy link
Collaborator Author

Commented by: @pcisar

Reopened because if this was back ported to 1.5, we should do the same for 2.0.

@firebird-automations
Copy link
Collaborator Author

Modified by: @pcisar

status: Resolved [ 5 ] => Reopened [ 4 ]

resolution: Fixed [ 1 ] =>

@firebird-automations
Copy link
Collaborator Author

Commented by: Claudio Valderrama C. (robocop)

Backported to v2.0.X as well.

@firebird-automations
Copy link
Collaborator Author

Modified by: Claudio Valderrama C. (robocop)

status: Reopened [ 4 ] => Resolved [ 5 ]

resolution: Fixed [ 1 ]

@firebird-automations
Copy link
Collaborator Author

Modified by: @dyemanov

Fix Version: 2.0.4 [ 10211 ]

@firebird-automations
Copy link
Collaborator Author

Modified by: @pcisar

status: Resolved [ 5 ] => Closed [ 6 ]

@firebird-automations
Copy link
Collaborator Author

Modified by: @pcisar

Workflow: jira [ 13101 ] => Firebird [ 13952 ]

@firebird-automations
Copy link
Collaborator Author

Modified by: @pavel-zotov

QA Status: No test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment