Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New builtin function DATEDIFF() implements wrong choice of keywords for expanded syntax [CORE1490] #1905

Closed
firebird-automations opened this issue Oct 1, 2007 · 6 comments

Comments

@firebird-automations
Copy link
Collaborator

Submitted by: @helebor

The expanded syntax for the newly-implemented built-in function is as follows:

DATEDIFF( <timestamp_part> FROM <date_time> FOR <date_time> )

Use of the prepositions FROM and FOR as keywords conveys the wrong semantics. The meaning should be expressed by a semantically correct pair of prepositions.

Suggested:
DATEDIFF( <timestamp_part> FROM <date_time> TO <date_time> )

or
DATEDIFF( <timestamp_part> BETWEEN <date_time> AND <date_time> )

A contracted alternative syntax is available, sans prepositions:

DATEDIFF( <timestamp_part>, <date_time>, <date_time> )

As a temporary measure, the Beta 2 release notes will include a warning that the keywords will change in Beta 3 and recommending use of the contracted syntax for the time being.

Commits: d8dde42

@firebird-automations
Copy link
Collaborator Author

Modified by: @asfernandes

Fix Version: 2.1 RC1 [ 10201 ]

assignee: Adriano dos Santos Fernandes [ asfernandes ]

summary: New inbuilt function DATEDIFF() implements wrong choice of keywords for expanded syntax => New builtin function DATEDIFF() implements wrong choice of keywords for expanded syntax

@firebird-automations
Copy link
Collaborator Author

Modified by: @asfernandes

status: Open [ 1 ] => Resolved [ 5 ]

resolution: Fixed [ 1 ]

@firebird-automations
Copy link
Collaborator Author

Commented by: @asfernandes

Changed TO: DATEDIFF( <timestamp_part> FROM <date_time> TO <date_time> )

@firebird-automations
Copy link
Collaborator Author

Modified by: @pcisar

Workflow: jira [ 13212 ] => Firebird [ 13983 ]

@firebird-automations
Copy link
Collaborator Author

Modified by: @pcisar

status: Resolved [ 5 ] => Closed [ 6 ]

@firebird-automations
Copy link
Collaborator Author

Modified by: @pavel-zotov

QA Status: No test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants