Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

isql doesn't mangle blob filter and udf information with embedded quotes when extracting a script. [CORE1493] #1908

Closed
firebird-automations opened this issue Oct 3, 2007 · 4 comments

Comments

@firebird-automations
Copy link
Collaborator

Submitted by: Claudio Valderrama C. (robocop)

Assigned to: Claudio Valderrama C. (robocop)

Is related to QA191

It's funny that after 7 years we still have problems with quoted identifiers. Example below:

F:\fb2dev\fbbuild\firebird2\temp\debug\firebird\bin>fbserver -a

F:\fb2dev\fbbuild\firebird2\temp\debug\firebird\bin>isql
Use CONNECT or CREATE DATABASE to specify a database
SQL> create database 'qi.fdb';
SQL> declare filter "xi""xa" input_type 0 output_type 1 entry_point 'dax''x' module_name 'my''mod';
SQL> declare external function "xe""xo" int returns int entry_point 'dox''x' module_name 'my''mod';
SQL> ^Z

F:\fb2dev\fbbuild\firebird2\temp\debug\firebird\bin>isql -x qi.fdb
Database: qi.fdb

SET SQL DIALECT 3;

/* CREATE DATABASE 'qi.fdb' DEFAULT CHARACTER SET NONE */

/* BLOB Filter declarations */
DECLARE FILTER xi"xa INPUT_TYPE 0 OUTPUT_TYPE 1
ENTRY_POINT 'dax'x' MODULE_NAME 'my'mod';

/* External Function declarations */
DECLARE EXTERNAL FUNCTION "xe""xo"
INTEGER
RETURNS INTEGER
ENTRY_POINT 'dox'x' MODULE_NAME 'my'mod';

The output should be instead, as expected:

/* BLOB Filter declarations */
DECLARE FILTER "xi""xa" INPUT_TYPE 0 OUTPUT_TYPE 1
ENTRY_POINT 'dax''x' MODULE_NAME 'my''mod';

/* External Function declarations */
DECLARE EXTERNAL FUNCTION "xe""xo"
INTEGER
RETURNS INTEGER
ENTRY_POINT 'dox''x' MODULE_NAME 'my''mod';

Commits: 16b18a9

@firebird-automations
Copy link
Collaborator Author

Modified by: Claudio Valderrama C. (robocop)

status: Open [ 1 ] => Resolved [ 5 ]

resolution: Fixed [ 1 ]

Fix Version: 2.1 RC1 [ 10201 ]

@firebird-automations
Copy link
Collaborator Author

Modified by: @pcisar

Link: This issue is related to QA191 [ QA191 ]

@firebird-automations
Copy link
Collaborator Author

Modified by: @pcisar

Workflow: jira [ 13230 ] => Firebird [ 13969 ]

@firebird-automations
Copy link
Collaborator Author

Modified by: @pavel-zotov

QA Status: No test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment