[#CORE-1594] BUG in CsConvert::convert - Firebird RDBMS Issue Tracker

Firebird Core

BUG in CsConvert::convert

Created: 14/Nov/07 03:31 PM Updated: 26/Dec/07 01:14 PM

Return to search

Component/s:

Engine

Affects Version/s:

2.1 Alpha 1, 2.1 Beta 1, 2.1 Beta 2

Fix Version/s:

2.1 RC1

Time Tracking:

Original Estimate:

1 hour

Remaining Estimate:

1 hour

Time Spent:

Not Specified

File Attachments:

CsConvert.h (8 kB)

Description

« Hide

Wrong cycle of ignore trailing spaces
- uses end of temp_buffer instead of end of data in temp_buffer

See corrected source in attach

---
PS. I make small refactoring of this code :))

All

Comments

Work Log

Change History

Version Control

Sort Order:

Kovalenko Dmitry made changes - 14/Nov/07 03:32 PM

Field	Original Value	New Value
Attachment		CsConvert.h [ 10650 ]

Dmitry Yemanov made changes - 14/Nov/07 04:12 PM

Assignee

Adriano dos Santos Fernandes [ asfernandes ]

Adriano dos Santos Fernandes made changes - 14/Nov/07 05:46 PM

Fix Version/s		2.1 RC1 [ 10201 ]
Affects Version/s		2.1 Beta 1 [ 10141 ]
Affects Version/s		2.1 Alpha 1 [ 10150 ]
Affects Version/s	2.0.3 [ 10200 ]

Adriano dos Santos Fernandes made changes - 14/Nov/07 05:46 PM

Resolution		Fixed [ 1 ]
Status	Open [ 1 ]	Resolved [ 5 ]

[ Permalink | « Hide ]

Alexander Peshkov added a comment - 16/Nov/07 03:27 AM

Dmitry, please take into an account for the future - doing reinterpret_cast<const USHORT*>(UCHAR*) (or any other cast leading to stronger alignment requirements) is very dangerous. If original data is not aligned properly, it will break all RISC builds (like sparc, parisc).
I understand that doing development on machines where alignment is not 'must be' thing makes us forget about alignment issues, but please remember that firebird is also used on other CPUs.

[ Permalink | « Hide ]

Kovalenko Dmitry added a comment - 16/Nov/07 04:27 PM

Alexander, I know about problems with bad-alignment by RISC machines. Thanks :)

And I know, also, than separation of generic "csconvert" on "csconvert_ucs2_to_mbc" and "csconvert_mbc_to_ucs2" can prevent this problems.

Pavel Cisar made changes - 26/Dec/07 01:14 PM

Status

Resolved [ 5 ]

Closed [ 6 ]

Pavel Cisar made changes - 28/Jan/08 01:17 PM

Workflow

jira [ 13414 ]

Firebird [ 14073 ]