Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ltrim('') and rtrim('') return NULL; rtrim forgets 1st char [CORE180] #507

Closed
firebird-automations opened this issue Jul 21, 2003 · 7 comments

Comments

@firebird-automations
Copy link
Collaborator

Submitted by: @paulvink

SFID: 774987#⁠
Submitted By: paulvink

ltrim and rtrim (both in ib_udf.c) return NULL if given an
empty string as argument.

Additionally, rtrim stops short of checking the first
character in the string, so it trims a string constisting of
1 or more spaces to ' ' (string with one space) instead
of '' (empty string). ltrim doesn't have this bug.

I've seen this in Windows SS 1.0.0, 1.0.3 and 1.6 Alpha,
but from the source it's obvious that this is an all-
versions thing.

Patches for both functions have been posted to firebird-
devel on 20 July 2003. They tested OK under the
abovementioned versions.

Grtz,
Paul Vinkenoog

@firebird-automations
Copy link
Collaborator Author

Commented by: Alice F. Bird (firebirds)

Date: 2004-11-18 21:54
Sender: skidder
Logged In: YES
user_id=495356

Also, Claudio later generally fixed NULL handling in UDF library

@firebird-automations
Copy link
Collaborator Author

Commented by: Alice F. Bird (firebirds)

Date: 2003-09-18 13:24
Sender: skidder
Logged In: YES
user_id=495356

Fixed both in 1.5 and HEAD branches

@firebird-automations
Copy link
Collaborator Author

Modified by: @dyemanov

assignee: skidder [ skidder ] => Dmitry Yemanov [ dimitr ]

status: Closed [ 6 ] => Reopened [ 4 ]

SF_ID: 774987 =>

@firebird-automations
Copy link
Collaborator Author

Modified by: @dyemanov

status: Reopened [ 4 ] => Resolved [ 5 ]

resolution: Fixed [ 1 ]

SF_ID: 774987 =>

@firebird-automations
Copy link
Collaborator Author

Modified by: @pcisar

status: Resolved [ 5 ] => Closed [ 6 ]

SF_ID: 774987 =>

@firebird-automations
Copy link
Collaborator Author

Modified by: @pcisar

Workflow: jira [ 10204 ] => Firebird [ 14427 ]

@firebird-automations
Copy link
Collaborator Author

Modified by: @pavel-zotov

QA Status: No test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants