Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow interactive arguments (seconds and intervals) of fb_lock_print to be 32-bit integers [CORE1906] #2337

Closed
firebird-automations opened this issue May 19, 2008 · 6 comments

Comments

@firebird-automations
Copy link
Collaborator

Submitted by: Steve Friedl (sjfriedl)

fb_lock_print -ia takes two numeric parameters - a number of seconds per interval, and a number of intervals, so one can do "fb_lock_print -ia 1 60" to see the lock stats every second for a minute. But the number-of-intervals is internally a SSHORT, and it's limited to 32767 for no particularly good reason.

By using an /int/ instead of a /short/, it fits the natural return value of atoi(), and I can't see any downside for this. The variable and parameter to the affected function are strictly internal, so this has no impact on any API anywhere.

Commits: abd3a32

@firebird-automations
Copy link
Collaborator Author

Modified by: @dyemanov

assignee: Dmitry Yemanov [ dimitr ]

@firebird-automations
Copy link
Collaborator Author

Modified by: @dyemanov

Version: 3.0 Initial [ 10301 ]

Version: 1.5.6 [ 10225 ]

Version: 2.1.3 [ 10302 ]

Version: 2.5 Beta 2 [ 10300 ]

Version: 2.5 Beta 1 [ 10251 ]

Version: 2.1.2 [ 10270 ]

Version: 2.0.5 [ 10222 ]

Version: 2.1.1 [ 10223 ]

Version: 2.5 Alpha 1 [ 10224 ]

Version: 2.1.0 [ 10041 ]

Version: 1.5.5 [ 10220 ]

Version: 2.0.3 [ 10200 ]

Version: 2.0.2 [ 10130 ]

Version: 2.0.1 [ 10090 ]

Version: 1.5.4 [ 10100 ]

Version: 2.0.0 [ 10091 ]

Fix Version: 3.0 Alpha 1 [ 10331 ]

summary: Allow fb_lock_print count to be a full int => Allow interactive arguments (seconds and intervals) of fb_lock_print to be 32-bit integers

@firebird-automations
Copy link
Collaborator Author

Modified by: @dyemanov

status: Open [ 1 ] => Resolved [ 5 ]

resolution: Fixed [ 1 ]

@firebird-automations
Copy link
Collaborator Author

Modified by: @dyemanov

Component: LOCK_PRINT [ 10120 ]

@firebird-automations
Copy link
Collaborator Author

Modified by: @pcisar

status: Resolved [ 5 ] => Closed [ 6 ]

@firebird-automations
Copy link
Collaborator Author

Modified by: @pavel-zotov

QA Status: No test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment