[#CORE-1923] "instsvc remove" returns 1 when succefully executed

Firebird Core

"instsvc remove" returns 1 when succefully executed

Created: 06/Jun/08 07:51 AM Updated: 08/Nov/09 06:39 PM

Component/s:

Scripts

Affects Version/s:

2.0.4

Fix Version/s:

2.5 Beta 1, 2.1.3, 2.0.6

Time Tracking:

Not Specified

Environment:

windows xp pro sp2

Planning Status:

Unspecified

Description

« Hide

When we SUCCESSFULLY execute "instsvc remove", part of firebird uninstallation, the command returns errorlevel 1.
This way our uninstallation script assumes the command has failed and fails.
The "instsvc remove" displays: Service "Firebird Server - DefaultInstance" successfully deleted.

instsvc stop, (called before remove)
and
instreg remove, (called after remove)

are successfully executed.

This did not happen in 1.5 releases.

All

Comments

Work Log

Change History

Version Control

FishEye

Sort Order:

[ Permalink | « Hide ]

Dmitry Yemanov added a comment - 06/Jun/08 08:15 AM

Am I right that it happens only when you setup the server *without* the guardian?

[ Permalink | « Hide ]

Gregory Kotsaftis added a comment - 07/Jun/08 01:25 PM

I do not use the neither the guardian nor the setup file for windows.
I just use the ZIP firebird installation, unzip it and manually call instsvc and instreg to install and uninstall the service.
Hope this helps...

[ Permalink | « Hide ]

Gregory Kotsaftis added a comment - 22/Jan/09 05:14 PM

Hi, I think I found the root of this problem.
It is found in "install_svc.cpp", line: 389

if (status != FB_SUCCESS && status2 != FB_SUCCESS)
status = FB_FAILURE;

This results to error if there is no Guardian installed to be removed (status).

Can someone verify this because my C++ knowledge is at least 15 years rusty...

Greg--