Issue Details (XML | Word | Printable)

Key: CORE-2187
Type: Improvement Improvement
Status: Resolved Resolved
Resolution: Fixed
Priority: Trivial Trivial
Assignee: Dmitry Yemanov
Reporter: Carlos H. Cantu
Votes: 1
Watchers: 6

If you were logged in you would be able to see more operations.
Firebird Core

Return the Hostname in mon$attachments

Created: 13/Nov/08 02:16 PM   Updated: 22/Aug/16 06:28 AM
Component/s: Engine
Affects Version/s: 2.1.0, 2.1.1, 2.1.3
Fix Version/s: 3.0 Alpha 1

Issue Links:

QA Status: Covered by another test(s)
Test Details: Reference to 'MON$REMOTE_HOST' is used in core_4135.fbt

 Description  « Hide
Add a new column to mon$attachments containg the Hostname of the client. Not sure if Hostname can be returned when protocol is not TCPIP, in this case, maybe it should return null.

 All   Comments   Change History   Subversion Commits      Sort Order: Ascending order - Click to sort in descending order
Alexander Peshkov added a comment - 14/Nov/08 04:42 AM
One minor issue with adding hostname column - it will require reverse DNS lookup, which may be slow sometimes. Certainly, in case when it's a problem one can not put this field in select list, but I already see an isssue in this tracker: after execute of 'SELECT * FROM MON$ATTACHMENTS' server sometimes hangs for a long time.

Dmitry Yemanov added a comment - 14/Nov/08 05:00 AM
It doesn't make any difference, whether this field is specified in the select list or not. All the fields are filled always, thus the DNS lookup will happen anyway, so there's no workaround.

Personally, I'd rather prefer to see this feature implemented either by a customer's UDF or at the client side (by a monitoring application or whatever).

Alexander Peshkov added a comment - 14/Nov/08 05:18 AM
May be add such UDF to fb_udf library?

Carlos H. Cantu added a comment - 14/Nov/08 07:21 AM
I agree that if there is a chance to make things slower, this feature should not be implemented as an internal field. In this case, Alex UDF proposal looks good, specially if it is included in fb_udf, as he suggested.

Vlad Khorsun added a comment - 14/Nov/08 12:22 PM
I vote that fbclient passed host name, fbclient version etc
For older fbclient there will be NULL's in MON$ATTACHMENTS

Alexander Peshkov added a comment - 14/Nov/08 01:01 PM
Vlad suggestion has one serious plus - it will work not only for TCP/IP, but also for PC/LAN. On the other hand, resolving host name via IP address is client-independent. And I do not think that this approachs exclude one another - we mat add field passed by fbclient and also add an UDF, that will invoke OS name resolver.