New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Return the Hostname in mon$attachments [CORE2187] #2617
Comments
Commented by: @AlexPeshkoff One minor issue with adding hostname column - it will require reverse DNS lookup, which may be slow sometimes. Certainly, in case when it's a problem one can not put this field in select list, but I already see an isssue in this tracker: after execute of 'SELECT * FROM MON$ATTACHMENTS' server sometimes hangs for a long time. |
Commented by: @dyemanov It doesn't make any difference, whether this field is specified in the select list or not. All the fields are filled always, thus the DNS lookup will happen anyway, so there's no workaround. Personally, I'd rather prefer to see this feature implemented either by a customer's UDF or at the client side (by a monitoring application or whatever). |
Commented by: @AlexPeshkoff May be add such UDF to fb_udf library? |
Commented by: @WarmBooter I agree that if there is a chance to make things slower, this feature should not be implemented as an internal field. In this case, Alex UDF proposal looks good, specially if it is included in fb_udf, as he suggested. |
Commented by: @hvlad I vote that fbclient passed host name, fbclient version etc |
Commented by: @AlexPeshkoff Vlad suggestion has one serious plus - it will work not only for TCP/IP, but also for PC/LAN. On the other hand, resolving host name via IP address is client-independent. And I do not think that this approachs exclude one another - we mat add field passed by fbclient and also add an UDF, that will invoke OS name resolver. |
Modified by: @dyemanovassignee: Dmitry Yemanov [ dimitr ] |
Modified by: @dyemanovstatus: Open [ 1 ] => In Progress [ 3 ] |
Modified by: @dyemanovstatus: In Progress [ 3 ] => Open [ 1 ] |
Modified by: @pavel-zotovQA Status: No test |
Modified by: @cincuranet |
Modified by: @pavel-zotovstatus: Resolved [ 5 ] => Resolved [ 5 ] QA Status: No test => Covered by another test(s) Test Details: Reference to 'MON$REMOTE_HOST' is used in core_4135.fbt |
Submitted by: @WarmBooter
Is related to QA636
Block progress on DNET652
Votes: 1
Add a new column to mon$attachments containg the Hostname of the client. Not sure if Hostname can be returned when protocol is not TCPIP, in this case, maybe it should return null.
Commits: 9f2a992
====== Test Details ======
Reference to 'MON$REMOTE_HOST' is used in core_4135.fbt
The text was updated successfully, but these errors were encountered: