Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal Firebird consistency check when alter dependent procedures [CORE2257] #2683

Closed
firebird-automations opened this issue Dec 24, 2008 · 12 comments

Comments

@firebird-automations
Copy link
Collaborator

Submitted by: Alex Bekhtin (afgm)

Is related to QA378

CREATE OR ALTER PROCEDURE B
AS
begin

end;

CREATE OR ALTER PROCEDURE A
AS
begin
execute procedure B;
end;

COMMIT WORK;

execute procedure A;

COMMIT WORK;

CREATE OR ALTER PROCEDURE B
AS
begin

end;

COMMIT WORK;

execute procedure A;

internal Firebird consistency check (invalid SEND request (167), file: exe.cpp line: 652).

Commits: b441891

@firebird-automations
Copy link
Collaborator Author

Commented by: @hvlad

Its side effect of fix for CORE210. In MET_procedure

- if (!procedure)
+ if (!procedure || procedure->prc_use_count)
{
procedure = FB_NEW(*dbb->dbb_permanent) jrd_prc(*dbb->dbb_permanent);
}

When i restored this line as it was before, BUGCHECK is gone.

The DWF\modify_procedure released procedure's request (proc B in our case) before call to MET_remove_procedure() therefore dependent procedure (proc A) refers to the obsolete copy of procedure with NULL prc_request.

@firebird-automations
Copy link
Collaborator Author

Commented by: @hvlad

I've assigned this ticket to Dmitry as found this bug introduced by fix for CORE210

@firebird-automations
Copy link
Collaborator Author

Modified by: @hvlad

assignee: Dmitry Yemanov [ dimitr ]

@firebird-automations
Copy link
Collaborator Author

Modified by: @dyemanov

status: Open [ 1 ] => In Progress [ 3 ]

@firebird-automations
Copy link
Collaborator Author

Modified by: @dyemanov

status: In Progress [ 3 ] => Open [ 1 ]

@firebird-automations
Copy link
Collaborator Author

Modified by: @dyemanov

status: Open [ 1 ] => Resolved [ 5 ]

resolution: Fixed [ 1 ]

@firebird-automations
Copy link
Collaborator Author

Modified by: @dyemanov

Fix Version: 2.5 Beta 1 [ 10251 ]

@firebird-automations
Copy link
Collaborator Author

Modified by: @pcisar

Link: This issue is related to QA378 [ QA378 ]

@firebird-automations
Copy link
Collaborator Author

Commented by: @pcisar

QA test added.

@firebird-automations
Copy link
Collaborator Author

Modified by: @pcisar

status: Resolved [ 5 ] => Closed [ 6 ]

@firebird-automations
Copy link
Collaborator Author

Modified by: @pavel-zotov

QA Status: No test

@firebird-automations
Copy link
Collaborator Author

Modified by: @pavel-zotov

QA Status: No test => Done successfully

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants