Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include PLAN in mon$statements [CORE2303] #2727

Closed
firebird-automations opened this issue Feb 2, 2009 · 11 comments
Closed

Include PLAN in mon$statements [CORE2303] #2727

firebird-automations opened this issue Feb 2, 2009 · 11 comments

Comments

@firebird-automations
Copy link
Collaborator

Submitted by: Douglas Tosi (douglasht)

Is related to QA639

Votes: 5

Currently, if the user wants to know the plan used for a certain statement, [s]he has to prepare the statement on a different attachment.
Depending on the number of statements, this may be an unacceptable overhead.
Plus, there is a change that some index changed after the original statement. The plan could then be different and the analysis compromised.

Please include the statement's PLAN in the monitoring tables. The most straight forward way I can think of is to include a mon$plan field in mon$statements.

Commits: 2c4b4f6 FirebirdSQL/fbt-repository@ca1cc98

@firebird-automations
Copy link
Collaborator Author

Modified by: @dyemanov

assignee: Dmitry Yemanov [ dimitr ]

@firebird-automations
Copy link
Collaborator Author

Modified by: @dyemanov

status: Open [ 1 ] => Open [ 1 ]

Fix Version: 3.0 Alpha 1 [ 10331 ]

@firebird-automations
Copy link
Collaborator Author

Commented by: @dyemanov

In Firebird 3, there are two kind of reported plans: legacy one and new detailed one. Honestly, I'd hate to have them both available in MON$STATEMENTS. Do you think it could be a problem if only the new plan will be reported?

@firebird-automations
Copy link
Collaborator Author

Modified by: @dyemanov

Fix Version: 3.0 Beta 1 [ 10332 ]

Fix Version: 3.0 Alpha 1 [ 10331 ] =>

@firebird-automations
Copy link
Collaborator Author

Modified by: @dyemanov

status: Open [ 1 ] => Resolved [ 5 ]

resolution: Fixed [ 1 ]

@firebird-automations
Copy link
Collaborator Author

Modified by: @dyemanov

issuetype: New Feature [ 2 ] => Improvement [ 4 ]

@firebird-automations
Copy link
Collaborator Author

Commented by: @livius2

Dimitry,
for big queries legacy plan is truncated - and there is no way to get full text of it
Then MON$STATEMENTS will be only place where we can got full text of them.
Why it is important?
As you remember legacy plan can be included in sql itself but explained plan not.
Because of that will be good to have it both

@firebird-automations
Copy link
Collaborator Author

Commented by: @dyemanov

Truncated detailed plans will be fixed (after Beta 2). Not every legacy plan can be specified in the SQL text, so it's pretty much useless for any complex query. So I'm still not sure we need to report legacy plans in MON$STATEMENTS.

@firebird-automations
Copy link
Collaborator Author

Commented by: @livius2

>>Truncated detailed plans will be fixed (after Beta 2).

Thank you :)

>>Not every legacy plan can be specified in the SQL text, so it's pretty much useless for any complex query. So I'm still not sure we need to report legacy plans in MON$STATEMENTS.

Ok - but you can adapt it and then use it
but if you do not see it at all (because truncation) you start from zero point

@firebird-automations
Copy link
Collaborator Author

Modified by: @pavel-zotov

status: Resolved [ 5 ] => Resolved [ 5 ]

QA Status: Done successfully

@firebird-automations
Copy link
Collaborator Author

Modified by: @pcisar

Link: This issue is related to QA639 [ QA639 ]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants