Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add prefix to the output for recovery process (by gfix or appropariate service) or put gfix/recovery output to the other file [CORE2383] #2805

Open
firebird-automations opened this issue Mar 21, 2009 · 9 comments
Open

Add prefix to the output for recovery process (by gfix or appropariate service) or put gfix/recovery output to the other file [CORE2383] #2805

firebird-automations opened this issue Mar 21, 2009 · 9 comments
Assignees
@hvlad
Labels
component: engine component: gfix priority: major type: improvement

Comments

@firebird-automations
Copy link
Collaborator

Submitted by: @SENikitin

Votes: 1

Often gfix produces thousands of messages, and writes it to the firebird.log. Number of these messages usually >> number of maintenance messages, so it's hard to recognize what is what and analyze gfix results, as well as "normal" messages.
Adding prefix like [gfix] to the recovery process messages will help to distinguish different type of message.
Separating output to another file (like check.log) can be even better, but it will require additional Service API call to get this file.
@firebird-automations
Copy link
Collaborator Author

Modified by: @dyemanov

Fix Version: 3.0 Alpha 1 [ 10331 ]

Version: 2.5 Beta 1 [ 10251 ] =>

Version: 3.0 Initial [ 10301 ] =>

@firebird-automations
Copy link
Collaborator Author

Modified by: @dyemanov

Fix Version: 3.0 Beta 1 [ 10332 ]

Fix Version: 3.0 Alpha 1 [ 10331 ] =>

@firebird-automations
Copy link
Collaborator Author

Modified by: @dyemanov

Fix Version: 3.0 Beta 2 [ 10586 ]

Fix Version: 3.0 Beta 1 [ 10332 ] =>

@firebird-automations
Copy link
Collaborator Author

Commented by: @dyemanov

I'd prefer every validation attempt to be logged into a separate file. Filename prefix could be hardcoded or configurable via firebird.conf, suffix would contain a textual timestamp. A good question is where these files should reside, as polluting the installation root with many files is not a good idea. I'd suggest a /logs sub-directory under the installation root. Maybe firebird.log should belong there as well, but I'm not sure.

As for the Services API, it could probably be extended to enumerate all files inside /logs and return them one by one. I don't know how much useful this feature is though.

@firebird-automations
Copy link
Collaborator Author

Commented by: @dyemanov

I feel that a proper implementation is too complex to be introduced during the v3 Beta stage. That said, we could really prefix the firebird.log lines like it was suggested in this ticket as a temporary measure. I leave it up to Vlad to decide.

@firebird-automations
Copy link
Collaborator Author

Modified by: @dyemanov

assignee: Vlad Khorsun [ hvlad ]

@firebird-automations
Copy link
Collaborator Author

Modified by: @dyemanov

Fix Version: 3.0 RC 1 [ 10584 ]

Fix Version: 3.0 Beta 2 [ 10586 ] =>

@firebird-automations
Copy link
Collaborator Author

Modified by: @dyemanov

Fix Version: 3.0.0 [ 10048 ]

Fix Version: 3.0 RC 1 [ 10584 ] =>

@firebird-automations
Copy link
Collaborator Author

Modified by: @dyemanov

Fix Version: 3.0 RC2 [ 10048 ] =>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hvlad hvlad

Labels
component: engine component: gfix priority: major type: improvement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hvlad @firebird-automations