New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Recreate DataTypeUtilBase::makeFromList [CORE2435] #2851
Comments
Modified by: @asfernandesassignee: Adriano dos Santos Fernandes [ asfernandes ] |
Commented by: Claudio Valderrama C. (robocop) When you say makeList, do you mean DataTypeUtilBase::makeFromList ??? |
Commented by: @asfernandes Yes, Claudio. Thanks. |
Modified by: @asfernandesdescription: What is now DataTypeUtil::makeList is a bugged monster function. No way to maintain it, as for CORE2361. Its comments got misleading and it does not work consistent re. blob sub types and charset/collatios. A much more clean and small routine is in the way. => What is now DataTypeUtilBase::makeFromList is a bugged monster function. No way to maintain it, as for CORE2361. Its comments got misleading and it does not work consistent re. blob sub types and charset/collatios. A much more clean and small routine is in the way. summary: Recreate DataTypeUtil::makeList => Recreate DataTypeUtilBase::makeFromList |
Commented by: @asfernandes Test script and result differences against old function. The output type is figured out as based on this order: If a blob is returned, and there is a binary blob in the list, a binary blob is returned. If a blob/text is returned, the returned charset is figured out as based on this order: |
Modified by: @asfernandesAttachment: http://core2361.sh [ 11441 ] Attachment: core2361.sql [ 11442 ] Attachment: core2361.txt [ 11443 ] |
Modified by: @asfernandesstatus: Open [ 1 ] => Resolved [ 5 ] resolution: Fixed [ 1 ] Fix Version: 2.5 RC1 [ 10300 ] |
Modified by: @pcisarstatus: Resolved [ 5 ] => Closed [ 6 ] |
Submitted by: @asfernandes
Jira_subtask_inward CORE2361
Attachments:
core2361.sh
core2361.sql
core2361.txt
What is now DataTypeUtilBase::makeFromList is a bugged monster function. No way to maintain it, as for CORE2361.
Its comments got misleading and it does not work consistent re. blob sub types and charset/collatios.
A much more clean and small routine is in the way.
Commits: 502f0f9
The text was updated successfully, but these errors were encountered: