Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make a single attachment usabe by more than one simultaneous threads in embedded [CORE2498] #1087

Closed
firebird-automations opened this issue Jun 6, 2009 · 6 comments

Comments

@firebird-automations
Copy link
Collaborator

Submitted by: @asfernandes

It was throwing "attachment handle is busy" error. Now callers will block until others requests are completed.

Commits: 2d8d9dd

@firebird-automations
Copy link
Collaborator Author

Modified by: @asfernandes

status: Open [ 1 ] => Resolved [ 5 ]

resolution: Fixed [ 1 ]

Fix Version: 2.5 RC1 [ 10300 ]

assignee: Adriano dos Santos Fernandes [ asfernandes ]

@firebird-automations
Copy link
Collaborator Author

Commented by: @AlexPeshkoff

Adriano, is it tested anyhow / anyway except SAS? I do not see any code problems at the first glance, but agree that we are trying to walk on a very thin ice at beta stage.

Next, I see at least one potential problem with this improvement - it makes possible to have bad programming style. Imagine MT application, which is using single attachment in all threads. With this improvement it will be very hard to notice any problem as long as such application is not running on SMP system under high load. And I can imagine a ticket like 'FB 2.5 badly supports SMP in MT environment'.

@firebird-automations
Copy link
Collaborator Author

Commented by: @dyemanov

Alex, I somewhat disagree. Surely we should clearly document that we don't support concurrent access to an attachment, regardless of whether we block or throw an error. As soon as it's documented, everybody stepping on this rake can be reasonably blamed in the support lists or the tracker. I'm not sure we can (or even should try to) protect from whatever stupid application users can code.

@firebird-automations
Copy link
Collaborator Author

Modified by: @pcisar

status: Resolved [ 5 ] => Closed [ 6 ]

@firebird-automations
Copy link
Collaborator Author

Modified by: @pavel-zotov

QA Status: No test

@firebird-automations
Copy link
Collaborator Author

Modified by: @pavel-zotov

status: Closed [ 6 ] => Closed [ 6 ]

QA Status: No test => Cannot be tested

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants