Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lack of several validations in gbak [CORE2545] #2955

Closed
firebird-automations opened this issue Jul 7, 2009 · 6 comments
Closed

Lack of several validations in gbak [CORE2545] #2955

firebird-automations opened this issue Jul 7, 2009 · 6 comments
Labels
affect-version: 1.5.4 affect-version: 1.5.5 affect-version: 2.0.0 affect-version: 2.0.1 affect-version: 2.0.2 affect-version: 2.0.3 affect-version: 2.0.4 affect-version: 2.0.5 affect-version: 2.1.0 affect-version: 2.1.1 affect-version: 2.1.2 affect-version: 2.5 Alpha 1 affect-version: 2.5 Beta 1 component: gbak fix-version: 3.0 Alpha 1 priority: minor type: bug

Comments

@firebird-automations
Copy link
Collaborator

Submitted by: Claudio Valderrama C. (robocop)

Assigned to: Claudio Valderrama C. (robocop)

Not very useful to the end user:
gbak ,
gbak: ERROR:Firebird::string - pos out of range

Undocumented skip (used for damaged backups) accepts negative offsets. When running as a service, it may trash the server.

It's possible to overflow the backup sizes just for fun, using large numbers plus G (giga).

Etc.

Commits: 08a33d5
@firebird-automations
Copy link
Collaborator Author

Modified by: Claudio Valderrama C. (robocop)

assignee: Claudio Valderrama C. [ robocop ]

@firebird-automations
Copy link
Collaborator Author

Commented by: Claudio Valderrama C. (robocop)

SKIP is not really a problem: it's covered by code that converts invalid input into zero.
Backup sizes for multi-file backup is an undetected problem since the size is limited to ULONG but it's unchecked.
Also, several backup options can be applied to restore and several restore options can be applied to backup (nonsense).

@firebird-automations
Copy link
Collaborator Author

Commented by: Claudio Valderrama C. (robocop)

NT and T can be applied simultaneously (the last one processed by the parsing logix wins).
Several options that have parameters can be specified many times, with different parameter values. For example, -fa 1 - fa 10 for backup. Again, the last one seen by the parsing logic is the winner.

@firebird-automations
Copy link
Collaborator Author

Modified by: Claudio Valderrama C. (robocop)

status: Open [ 1 ] => Resolved [ 5 ]

resolution: Fixed [ 1 ]

Fix Version: 3.0 Alpha 1 [ 10331 ]

@firebird-automations
Copy link
Collaborator Author

Modified by: @pcisar

status: Resolved [ 5 ] => Closed [ 6 ]

@firebird-automations
Copy link
Collaborator Author

Modified by: @pavel-zotov

QA Status: No test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affect-version: 1.5.4 affect-version: 1.5.5 affect-version: 2.0.0 affect-version: 2.0.1 affect-version: 2.0.2 affect-version: 2.0.3 affect-version: 2.0.4 affect-version: 2.0.5 affect-version: 2.1.0 affect-version: 2.1.1 affect-version: 2.1.2 affect-version: 2.5 Alpha 1 affect-version: 2.5 Beta 1 component: gbak fix-version: 3.0 Alpha 1 priority: minor type: bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@firebird-automations