Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

isql hangs when trying to show a view based on a procedure [CORE2735] #3130

Closed
firebird-automations opened this issue Nov 6, 2009 · 7 comments

Comments

@firebird-automations
Copy link
Collaborator

Submitted by: Claudio Valderrama C. (robocop)

Assigned to: Claudio Valderrama C. (robocop)

Is related to QA423

SQL> set term ^;
SQL> create procedure p returns(a int) as begin a = 9; suspend; end^
SQL> create view vp1 as select a from p^
SQL> set term ;^
SQL> show view vp1;
A INTEGER^C

(had to be killed and hence the ^C in the output).

The reason is that isql is not prepared to find view field's sources in procedures and therefore ISQL_get_base_column_null_flag (called by ISQL_get_null_flag and this by show_table) goes in an infinite loop. The code should indicate to the caller when it can't find the required field.

The code should check also procedure parameters. I continue thinking that putting the type of source field in rdb$view_relations would simplify code in the long term and we would know where to check instead of digging in tables and procedures and who knows what else more in the future.

Commits: cd28279 31848bf 1399401 094320e 22af8f1

@firebird-automations
Copy link
Collaborator Author

Commented by: @dyemanov

IIRC, this feature has been introduced in v2.5, so I've marked that version as affected as well.

@firebird-automations
Copy link
Collaborator Author

Modified by: @dyemanov

Version: 3.0 Initial [ 10301 ]

Version: 2.5 Beta 2 [ 10300 ]

Version: 3.0 Alpha 1 [ 10331 ] =>

@firebird-automations
Copy link
Collaborator Author

Modified by: @asfernandes

assignee: Claudio Valderrama C. [ robocop ]

@firebird-automations
Copy link
Collaborator Author

Modified by: Claudio Valderrama C. (robocop)

status: Open [ 1 ] => Resolved [ 5 ]

resolution: Fixed [ 1 ]

Fix Version: 2.5 RC2 [ 10372 ]

Fix Version: 3.0 Alpha 1 [ 10331 ]

@firebird-automations
Copy link
Collaborator Author

Modified by: @pcisar

Link: This issue is related to QA423 [ QA423 ]

@firebird-automations
Copy link
Collaborator Author

Modified by: @pmakowski

status: Resolved [ 5 ] => Closed [ 6 ]

@firebird-automations
Copy link
Collaborator Author

Modified by: @pavel-zotov

status: Closed [ 6 ] => Closed [ 6 ]

QA Status: Done successfully

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant