Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to the trace plugin to configure traced services events on per-service name basis [CORE2767] #3159

Closed
firebird-automations opened this issue Nov 22, 2009 · 6 comments

Comments

@firebird-automations
Copy link
Collaborator

Submitted by: @hvlad

Extend syntax of <service> section of trace configuration and make it the same as for <database> section.
I.e. allow <service [pattern]> syntax, where optional "pattern" is matched against name of service, such as "Backup Database", "Repair Database" etc.
Full list of currently used names already present in svc.spp and should be part of sample fbtrace.conf file.

Commits: 950bcd8 0335e1c

@firebird-automations
Copy link
Collaborator Author

Modified by: @hvlad

assignee: Vlad Khorsun [ hvlad ]

@firebird-automations
Copy link
Collaborator Author

Modified by: @hvlad

status: Open [ 1 ] => In Progress [ 3 ]

@firebird-automations
Copy link
Collaborator Author

Commented by: @hvlad

Unfortunately, proposed way to configure individual service is not possible with current implementation. The problem is that configuration passed to the trace plugin only at time when service attachment is created and at this time service task name is not known. It will known at time when service will start. Also note that same service attachment is able to run another task when current task is finished.

Therefore i implemented another, less elegant but also useful way to configure which services should be traced (or not traced). Now "include_filter" and "exclude_filter" regular expressions also allowed in <services> section and when some service task is started (or queried) its name is matched agains this filters to determine if corresponding event should be logged.

@firebird-automations
Copy link
Collaborator Author

Modified by: @hvlad

status: In Progress [ 3 ] => Resolved [ 5 ]

resolution: Fixed [ 1 ]

Fix Version: 2.5 RC2 [ 10372 ]

Fix Version: 3.0 Alpha 1 [ 10331 ]

@firebird-automations
Copy link
Collaborator Author

Modified by: @pcisar

status: Resolved [ 5 ] => Closed [ 6 ]

@firebird-automations
Copy link
Collaborator Author

Modified by: @pavel-zotov

QA Status: No test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment