Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bad extraction syntax for procedure's parameter based on table's field [CORE2792] #3182

Closed
firebird-automations opened this issue Dec 4, 2009 · 5 comments

Comments

@firebird-automations
Copy link
Collaborator

Submitted by: Claudio Valderrama C. (robocop)

Assigned to: Claudio Valderrama C. (robocop)

When a parameters depends on a table field, the syntax is TYPE OF COLUMN. This was done in the SHOW PROCEDURE code but not when extracting a full script:

F:\fb2dev\fbbuild\firebird25\temp\Win32\Debug\firebird\bin>isql
Use CONNECT or CREATE DATABASE to specify a database
SQL> create database 'badproc.fdb';
SQL> create table t(a int);
SQL> create procedure p(p_a type of column t.a) as begin end;
SQL> ^Z

F:\fb2dev\fbbuild\firebird25\temp\Win32\Debug\firebird\bin>isql -x BADPROC.FDB
Database: BADPROC.FDB

SET SQL DIALECT 3;

/* CREATE DATABASE 'BADPROC.FDB' PAGE_SIZE 4096 DEFAULT CHARACTER SET NONE */

/* Table: T, Owner: ATENEA\CLAUDIO */
CREATE TABLE T (A INTEGER);
COMMIT WORK;
SET AUTODDL OFF;
SET TERM ^ ;

/* Stored procedures */
CREATE PROCEDURE P (P_A TYPE OF T.A)
AS
BEGIN EXIT; END ^

ALTER PROCEDURE P (P_A TYPE OF T.A)
AS
begin end ^
SET TERM ; ^
COMMIT WORK ;
SET AUTODDL ON;

Should be TYPE OF COLUMN T.A instead.

Commits: d2013e6 50f7202

====== Test Details ======

Test not needed here: see test for CORE5089 instead.

@firebird-automations
Copy link
Collaborator Author

Modified by: Claudio Valderrama C. (robocop)

assignee: Claudio Valderrama C. [ robocop ]

@firebird-automations
Copy link
Collaborator Author

Modified by: Claudio Valderrama C. (robocop)

status: Open [ 1 ] => Resolved [ 5 ]

resolution: Fixed [ 1 ]

Fix Version: 2.5 RC2 [ 10372 ]

Fix Version: 3.0 Alpha 1 [ 10331 ]

@firebird-automations
Copy link
Collaborator Author

Modified by: @pcisar

status: Resolved [ 5 ] => Closed [ 6 ]

@firebird-automations
Copy link
Collaborator Author

Modified by: @pavel-zotov

QA Status: No test

@firebird-automations
Copy link
Collaborator Author

Modified by: @pavel-zotov

status: Closed [ 6 ] => Closed [ 6 ]

QA Status: No test => Done successfully

Test Details: Test not needed here: see test for CORE5089 instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment