Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

isql shouldn't display db and user name when extracting a script [CORE2831] #3217

Closed
firebird-automations opened this issue Jan 28, 2010 · 8 comments

Comments

@firebird-automations
Copy link
Collaborator

Submitted by: Claudio Valderrama C. (robocop)

Assigned to: Claudio Valderrama C. (robocop)

Is related to QA253

F:\fb2dev\fbbuild\firebird25\temp\Win32\Debug\firebird\bin>isql -x tre.fdb
Database: tre.fdb

SET SQL DIALECT 3;

/* CREATE DATABASE 'tre.fdb' PAGE_SIZE 4096 DEFAULT CHARACTER SET NONE */

[etc]

F:\fb2dev\fbbuild\firebird25\temp\Win32\Debug\firebird\bin>isql -x tre.fdb -user sysdba -pass masterkey
Database: tre.fdb, User: sysdba

SET SQL DIALECT 3;

/* CREATE DATABASE 'tre.fdb' PAGE_SIZE 4096 DEFAULT CHARACTER SET NONE */

[etc]

The database name and user's name are information items that should be deleted before making a script work. Extracting a script should be considered a non-interactive operation (even if sent to the console instead of redirected with -o) and old comments inforce the idea that the user shouldn't be dumped to a script.

Commits: e3c8df4 12e86a3 b12b085 302f149

====== Test Details ======

Could reproduce only in WI-V2.1.0.17798:

Database: <host/port:path/file.fdb>, User: sysdba
SET SQL DIALECT 3;
...

Original 'substitutions' section has been replaced.

@firebird-automations
Copy link
Collaborator Author

Modified by: Claudio Valderrama C. (robocop)

assignee: Claudio Valderrama C. [ robocop ]

@firebird-automations
Copy link
Collaborator Author

Modified by: Claudio Valderrama C. (robocop)

status: Open [ 1 ] => Resolved [ 5 ]

resolution: Fixed [ 1 ]

Fix Version: 2.5 RC2 [ 10372 ]

Fix Version: 2.0.6 [ 10303 ]

Fix Version: 2.1.4 [ 10361 ]

Fix Version: 3.0 Alpha 1 [ 10331 ]

@firebird-automations
Copy link
Collaborator Author

Modified by: @pcisar

Link: This issue is related to QA253 [ QA253 ]

@firebird-automations
Copy link
Collaborator Author

Modified by: @pcisar

status: Resolved [ 5 ] => Closed [ 6 ]

@firebird-automations
Copy link
Collaborator Author

Commented by: @pcisar

Test added.

@firebird-automations
Copy link
Collaborator Author

Modified by: @pavel-zotov

status: Closed [ 6 ] => Closed [ 6 ]

QA Status: Done successfully

@firebird-automations
Copy link
Collaborator Author

Modified by: @pavel-zotov

status: Closed [ 6 ] => Closed [ 6 ]

Test Details: Could reproduce only in WI-V2.1.0.17798:

Database: <host/port:path/file.fdb>, User: sysdba
SET SQL DIALECT 3;
...

@firebird-automations
Copy link
Collaborator Author

Modified by: @pavel-zotov

status: Closed [ 6 ] => Closed [ 6 ]

Test Details: Could reproduce only in WI-V2.1.0.17798:

Database: <host/port:path/file.fdb>, User: sysdba
SET SQL DIALECT 3;
...

=>

Could reproduce only in WI-V2.1.0.17798:

Database: <host/port:path/file.fdb>, User: sysdba
SET SQL DIALECT 3;
...

Original 'substitutions' section has been replaced.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment