isql shouldn't display db and user name when extracting a script [CORE2831] #3217
Labels
affect-version: 2.0.0
affect-version: 2.0.1
affect-version: 2.0.2
affect-version: 2.0.3
affect-version: 2.0.4
affect-version: 2.0.5
affect-version: 2.0.6
affect-version: 2.1.0
affect-version: 2.1.1
affect-version: 2.1.2
affect-version: 2.1.3
affect-version: 2.1.4
affect-version: 2.5 Alpha 1
affect-version: 2.5 Beta 1
affect-version: 2.5 Beta 2
affect-version: 2.5 RC1
affect-version: 2.5 RC2
affect-version: 3.0 Alpha 1
affect-version: 3.0 Initial
component: isql
fix-version: 2.0.6
fix-version: 2.1.4
fix-version: 2.5 RC2
fix-version: 3.0 Alpha 1
priority: trivial
qa: done successfully
type: bug
Submitted by: Claudio Valderrama C. (robocop)
Assigned to: Claudio Valderrama C. (robocop)
Is related to QA253
F:\fb2dev\fbbuild\firebird25\temp\Win32\Debug\firebird\bin>isql -x tre.fdb
Database: tre.fdb
SET SQL DIALECT 3;
/* CREATE DATABASE 'tre.fdb' PAGE_SIZE 4096 DEFAULT CHARACTER SET NONE */
[etc]
F:\fb2dev\fbbuild\firebird25\temp\Win32\Debug\firebird\bin>isql -x tre.fdb -user sysdba -pass masterkey
Database: tre.fdb, User: sysdba
SET SQL DIALECT 3;
/* CREATE DATABASE 'tre.fdb' PAGE_SIZE 4096 DEFAULT CHARACTER SET NONE */
[etc]
The database name and user's name are information items that should be deleted before making a script work. Extracting a script should be considered a non-interactive operation (even if sent to the console instead of redirected with -o) and old comments inforce the idea that the user shouldn't be dumped to a script.
Commits: e3c8df4 12e86a3 b12b085 302f149
====== Test Details ======
Could reproduce only in WI-V2.1.0.17798:
Database: <host/port:path/file.fdb>, User: sysdba
SET SQL DIALECT 3;
...
Original 'substitutions' section has been replaced.
The text was updated successfully, but these errors were encountered: