Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot remove user with dot in login [CORE2861] #3245

Closed
firebird-automations opened this issue Feb 12, 2010 · 8 comments
Closed

Cannot remove user with dot in login [CORE2861] #3245

firebird-automations opened this issue Feb 12, 2010 · 8 comments

Comments

@firebird-automations
Copy link
Collaborator

Submitted by: @cincuranet

Is duplicated by CORE3000

When I try to delete user with dot in login via services API or gsec I get error:
./gsec -delete 'foo.bar'
An error occurred while attempting to delete the user record.
Dynamic SQL Error
SQL error code = -104
Token unknown - line 1, column 29
.

====== Test Details ======

Since 10.01.2016 this test (for 3.0) is based on totally new algorithm with checking ability of
normal work with randomly generated logins. These logins consists only of punctuation chars and
for sure will have at least one dot.
The reason of this replacement was failed results on Classic 3.0 when 'gsec' utility is invoked.
Code for 2.5 was not changed and is preserved (though it was missed for 2.5 before, but it works OK).

See http://web.firebirdsql.org/download/prerelease/results/archive/ for builds: 3.0.0.32266 3.0.0.32268

Correctness of current code was verified by batch scenario, totally about ~1500 iterations was done.
Several samples of logins that were be checked:
,(/;.>_:%$^`.&<|#⁠?=[~\*}-{@)
>=[{+%\.&|~$`(;#⁠._,])}?*@:^!
}^\*@.)#⁠>|/;&!=~`]<[,?.-:(%.

NOTE: currently we EXCLUDE single and double quotes from random login because of CORE5072.

This login is handled then by both FBSVCMGR and ISQL utilities:
1) run FBSVCMGR and:
1.1) add user
1.2) modifying some of its attributes (password, firstname etc).
NOTE! We do *not* run 'fbsvcmgr action_delete_user' because it does not work (at least on build 32268)
COMMAND:
fbsvcmgr localhost/3333:service_mgr user sysdba password masterkey ^
action_delete_user dbname C:\MIX\firebird\fb30\security3.fdb ^
sec_username john
STDERR: unexpected item in service parameter block, expected isc_spb_sec_username
(sent letter to Alex, 09-jan-2016 22:34; after getting reply about this issue test can be further changed).
2) run ISQL and:
2.1) drop this user that could not be dropped in FBSVCMGR - see previous section.
2.2) create this login again;
2.3) modifying some of this login attributes;
2.4) drop it finally.

@firebird-automations
Copy link
Collaborator Author

Modified by: @dyemanov

assignee: Alexander Peshkov [ alexpeshkoff ]

@firebird-automations
Copy link
Collaborator Author

Modified by: @AlexPeshkoff

Link: This issue is duplicated by CORE3000 [ CORE3000 ]

@firebird-automations
Copy link
Collaborator Author

Commented by: @AlexPeshkoff

Bug (though looking a but differently) is caused by exactly same reason - missing quotes in SQL statement generated by gsec.

@firebird-automations
Copy link
Collaborator Author

Commented by: @AlexPeshkoff

already fixed dup issue 3000

@firebird-automations
Copy link
Collaborator Author

Modified by: @AlexPeshkoff

status: Open [ 1 ] => Resolved [ 5 ]

resolution: Fixed [ 1 ]

Fix Version: 2.5 RC3 [ 10381 ]

Fix Version: 3.0 Alpha 1 [ 10331 ]

@firebird-automations
Copy link
Collaborator Author

Modified by: @pcisar

status: Resolved [ 5 ] => Closed [ 6 ]

@firebird-automations
Copy link
Collaborator Author

Modified by: @pavel-zotov

status: Closed [ 6 ] => Closed [ 6 ]

QA Status: Done successfully

@firebird-automations
Copy link
Collaborator Author

Modified by: @pavel-zotov

status: Closed [ 6 ] => Closed [ 6 ]

Test Details: Since 10.01.2016 this test (for 3.0) is based on totally new algorithm with checking ability of
normal work with randomly generated logins. These logins consists only of punctuation chars and
for sure will have at least one dot.
The reason of this replacement was failed results on Classic 3.0 when 'gsec' utility is invoked.
Code for 2.5 was not changed and is preserved (though it was missed for 2.5 before, but it works OK).

See http://web.firebirdsql.org/download/prerelease/results/archive/ for builds: 3.0.0.32266 3.0.0.32268

Correctness of current code was verified by batch scenario, totally about ~1500 iterations was done.
Several samples of logins that were be checked:
,(/;.>_:%$^`.&<|#⁠?=[~\*}-{@)
>=[{+%\.&|~$`(;#⁠._,])}?*@:^!
}^\*@.)#⁠>|/;&!=~`]<[,?.-:(%.

NOTE: currently we EXCLUDE single and double quotes from random login because of CORE5072.

This login is handled then by both FBSVCMGR and ISQL utilities:
1) run FBSVCMGR and:
1.1) add user
1.2) modifying some of its attributes (password, firstname etc).
NOTE! We do *not* run 'fbsvcmgr action_delete_user' because it does not work (at least on build 32268)
COMMAND:
fbsvcmgr localhost/3333:service_mgr user sysdba password masterkey ^
action_delete_user dbname C:\MIX\firebird\fb30\security3.fdb ^
sec_username john
STDERR: unexpected item in service parameter block, expected isc_spb_sec_username
(sent letter to Alex, 09-jan-2016 22:34; after getting reply about this issue test can be further changed).
2) run ISQL and:
2.1) drop this user that could not be dropped in FBSVCMGR - see previous section.
2.2) create this login again;
2.3) modifying some of this login attributes;
2.4) drop it finally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment