Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configure --with-fbudf breaks build on CentOS [CORE2862] #3246

Closed
firebird-automations opened this issue Feb 13, 2010 · 10 comments
Closed

configure --with-fbudf breaks build on CentOS [CORE2862] #3246

firebird-automations opened this issue Feb 13, 2010 · 10 comments

Comments

@firebird-automations
Copy link
Collaborator

Submitted by: Mike Pomraning (pilcrow)

Expected behavior:
Specifying ''configure ... --with-fbudf=/whatever ..." will complete configuration without difficulty.

Observed behavior:
Specifying ''configure ... --with-fbudf=/whatever ..." causes configuration to abort with the following error messages:

\.\.\.
checking for /proc/self/exe\.\.\. yes
configure: creating \./config\.status
files are identical
config\.status: creating gen/install/misc/firebird\.conf
sed: file \./confstatx21610/subs\-3\.sed line 43: unterminated \`s' command
config\.status: creating gen/install/misc/aliases\.conf
sed: file \./confstatx21610/subs\-3\.sed line 43: unterminated \`s' command
config\.status: creating gen/install/misc/fbintl\.conf
sed: file \./confstatx21610/subs\-3\.sed line 43: unterminated \`s' command
config\.status: creating gen/install/misc/fbtrace\.conf
\.\.\. and so on \.\.\.

Comment:
Problem appears to be in http://configure.in's setting of UDF_COMMENT to a multiline string -- this substitution then confuses sed(1), as shown above.

Background:
[fb ~]$ uname -a; rpm -q centos-release autoconf automakeLinux fajrobirdo 2.6.18-164.11.1.el5 #⁠1 SMP Wed Jan 20 07:39:04 EST 2010 i686 i686 i386 GNU/Linux
centos-release-5-4.el5.centos.1
autoconf-2.59-12
automake-1.9.6-2.1

Commits: 84e0027 5f52b1b

@firebird-automations
Copy link
Collaborator Author

Modified by: @dyemanov

assignee: Alexander Peshkov [ alexpeshkoff ]

@firebird-automations
Copy link
Collaborator Author

Commented by: @AlexPeshkoff

Works for me using:

autoconf (GNU Autoconf) 2.63
automake (GNU automake) 1.10.2

I'm not 100% sure, should we better avoid mutlilines or require fresh tools. Let's wait what others say.

@firebird-automations
Copy link
Collaborator Author

Commented by: @pmakowski

what a bad news :(

Mike as an immediate solution you can setup fresher tools (see for example http://pdos.csail.mit.edu/pipermail/click/2008-November/007444.html)

Firebird 2.5, autoconf 2.6 and automake 1.10 will never be in official Centos / EPEL repositories , it would break their rules.

So if someone wanted to build Firebird for Centos 5, or make rpm for this distro, he have to patch it self the sources.

And for what I see in Distrowatch, Centos 5.4, RH 5,4 is the last distro stil maintained using these old version of autoconf and automake, even the oldest Debian maintained (4.0 Etch) is using autoconf 2.6 and automake 1.10

I don't think that the Firebird project have to solve this issue.
But I think we should put somewhere in the Release Notes and/or readme that autoconf 2.6 and automake 1.10 are the minimal version to build Firebird 2.5

@firebird-automations
Copy link
Collaborator Author

Commented by: @AlexPeshkoff

We have required version check in http://autogen.sh. Should I change requiements in it?

@firebird-automations
Copy link
Collaborator Author

Commented by: Mike Pomraning (pilcrow)

makowski wrote:
> Firebird 2.5, autoconf 2.6 and automake 1.10 will never be in official Centos / EPEL repositories ,
> it would break their rules.

Agreed. However, I'd encourage you to make contemporary CentOS/Red Hat support as easy as possible, to improve Firebird's market penetration (at least in the U.S. enterprise). It's very easy for the CentOS/RH admin or developer to install current Postgres, Oracle-XE or DB2 Express-C from 3rd-party repos, FWIW.

Either reworking UDF_COMMENT -- which seems a very small and easy thing to me -- or updating the http://autogen.sh requirements, as alexpeshkoff suggested, to the toolset shipped with the oldest OS that the FB developers do wish to support. If CentOS/RH isn't part of that officially supported list, I'll continue to patch around it. :)

Thanks for looking in to this issue.

@firebird-automations
Copy link
Collaborator Author

Commented by: @AlexPeshkoff

Taking into an account, that autoconf suite is to be run only at developers' boxes (for install one should use prebuilt configure in tarball), version check is correct solution here.

@firebird-automations
Copy link
Collaborator Author

Modified by: @AlexPeshkoff

status: Open [ 1 ] => Resolved [ 5 ]

resolution: Fixed [ 1 ]

Fix Version: 2.5 RC3 [ 10381 ]

Fix Version: 3.0 Alpha 1 [ 10331 ]

@firebird-automations
Copy link
Collaborator Author

Modified by: @pcisar

status: Resolved [ 5 ] => Closed [ 6 ]

@firebird-automations
Copy link
Collaborator Author

Modified by: @pavel-zotov

QA Status: No test

@firebird-automations
Copy link
Collaborator Author

Modified by: @pavel-zotov

status: Closed [ 6 ] => Closed [ 6 ]

QA Status: No test => Cannot be tested

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment