Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When server gets unavailbale, client does not perform detach correctly [CORE3269] #3637

Closed
firebird-automations opened this issue Dec 1, 2010 · 8 comments

Comments

@firebird-automations
Copy link
Collaborator

Submitted by: vander clock stephane (arkadia)

if we call isc_detach_database and for exemple the firbird server was crashed before then isc_detach_database not free the resource used by the DBhandle

It's confirmed by Alex peshkoff :

"I confirm presence of a problem here.
Moreover, there is a small memory leak.
Please add bug to the tracker."

I also thing it's the same for the transaction ....

also i thing that it's little confusing than in case of exception that the DBhandle is not set to nil ...
leaving it to point to a not null value can mean it is not free ... (because what the purpose to
free it and to not set it to null in case of exception ?)

Commits: 445bd69

@firebird-automations
Copy link
Collaborator Author

Modified by: @AlexPeshkoff

assignee: Alexander Peshkov [ alexpeshkoff ]

@firebird-automations
Copy link
Collaborator Author

Modified by: @AlexPeshkoff

status: Open [ 1 ] => Open [ 1 ]

Target: 3.0 Alpha 1 [ 10331 ]

@firebird-automations
Copy link
Collaborator Author

Modified by: @AlexPeshkoff

Version: 3.0 Initial [ 10301 ]

summary: isc_detach_database => memory leaks => When server gets unavailbale, client does not delete objects correctly

@firebird-automations
Copy link
Collaborator Author

Modified by: @AlexPeshkoff

summary: When server gets unavailbale, client does not delete objects correctly => When server gets unavailbale, client does not perform detach correctly

@firebird-automations
Copy link
Collaborator Author

Commented by: @AlexPeshkoff

What about 2.5 - I did not test ancient 2.5.0, but in current snapshots behavior is correct: in case of network error isc_detach_database() succeeds writing a record to the log file. Handle is set to 0.

@firebird-automations
Copy link
Collaborator Author

Modified by: @AlexPeshkoff

status: Open [ 1 ] => Resolved [ 5 ]

resolution: Fixed [ 1 ]

Fix Version: 3.0 Alpha 1 [ 10331 ]

@firebird-automations
Copy link
Collaborator Author

Modified by: @pcisar

status: Resolved [ 5 ] => Closed [ 6 ]

@firebird-automations
Copy link
Collaborator Author

Modified by: @pavel-zotov

QA Status: No test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants