Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression: Code changes disabled support for expression indexes with COALESCE, CASE and DECODE [CORE3338] #3704

Closed
firebird-automations opened this issue Feb 6, 2011 · 5 comments

Comments

@firebird-automations
Copy link
Collaborator

Submitted by: @asfernandes

FB 2.5 introduced fixes related to COALESCE, CASE and DECODE expressions to not duplicate sub-expressions in BLR, which was slow and had some bugs. This has made with new blr_stmt_expr. But this new BLR verb turn to be very difficult to support, specially in the optimizer.

As a result of it, some bugs (CORE3310, for example) were introduced, and some expression indexes stopped to work.

An example of an expression index not working anymore: COMPUTED BY (COALESCE(N * 2, 0)).

The complete (for FB 3) solution for these problems is:
1) introduce new specialized BLR verbs for COALESCE and DECODE/CASE;
2) transform blr_stmt_expr to new nodes when parsing legacy BLR.

Solution for 2.5 still need more analysis.

Commits: bf77761

@firebird-automations
Copy link
Collaborator Author

Modified by: @asfernandes

assignee: Adriano dos Santos Fernandes [ asfernandes ]

@firebird-automations
Copy link
Collaborator Author

Modified by: Sean Leyne (seanleyne)

summary: Some expression indexes with COALESCE, CASE and DECODE became inoperant => Regression: Code changes disabled support for expression indexes with COALESCE, CASE and DECODE

@firebird-automations
Copy link
Collaborator Author

Modified by: @asfernandes

status: Open [ 1 ] => Resolved [ 5 ]

resolution: Fixed [ 1 ]

Fix Version: 3.0 Alpha 1 [ 10331 ]

@firebird-automations
Copy link
Collaborator Author

Modified by: @pcisar

status: Resolved [ 5 ] => Closed [ 6 ]

@firebird-automations
Copy link
Collaborator Author

Modified by: @pavel-zotov

status: Closed [ 6 ] => Closed [ 6 ]

QA Status: Done successfully

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment