Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve diagnostics of internal trace errors [CORE3413] #3776

Closed
firebird-automations opened this issue Mar 25, 2011 · 5 comments
Closed

Improve diagnostics of internal trace errors [CORE3413] #3776

firebird-automations opened this issue Mar 25, 2011 · 5 comments

Comments

@firebird-automations
Copy link
Collaborator

Submitted by: @hvlad

In 2.5.0 all internal errors thrown by the trace plugin itself are logged at firebird.log. For example, when trace configuration contains regular expression in wrong syntax, wrong element, etc.

While this is OK for system audit it is not user-friendly (and even not necessary) for user trace sessions.

Improvement is to put such errors into trace output and not into firebird.log whenever possible.

Commits: 54221b3 ad6033e 39ab4e7 4290ac6

@firebird-automations
Copy link
Collaborator Author

Modified by: @hvlad

assignee: Vlad Khorsun [ hvlad ]

@firebird-automations
Copy link
Collaborator Author

Modified by: @hvlad

status: Open [ 1 ] => Resolved [ 5 ]

resolution: Fixed [ 1 ]

Fix Version: 2.5.1 [ 10333 ]

Fix Version: 3.0 Alpha 1 [ 10331 ]

@firebird-automations
Copy link
Collaborator Author

Modified by: @pcisar

status: Resolved [ 5 ] => Closed [ 6 ]

@firebird-automations
Copy link
Collaborator Author

Modified by: @pavel-zotov

status: Closed [ 6 ] => Closed [ 6 ]

QA Status: Done successfully

Test Details: Implemented for execution on Windows only.
1) This test uses async. calls of external routine (fbsvcmgr) with opening it in separate command window,
see: subprocess.call('start /min cmd /c ...', shell=True).
2) It was encountered that launching trace session by FBSVCMGR requires 1-2 seconds to be finished,
so this test intentionally uses delay (see calls `time.sleep()`).
3) Format of `database` section differ in 2.5 vs 3.0, so two separate sections have been created here for each FB version.
4) Correct work was checked on: WI-V2.5.5.26914 (SS, SC) and WI-V3.0.0.31940 (SS, SC and CS).

Test Specifics: [Platform (Windows/Linux) specific]

@firebird-automations
Copy link
Collaborator Author

Modified by: @pavel-zotov

status: Closed [ 6 ] => Closed [ 6 ]

Test Details: Implemented for execution on Windows only.
1) This test uses async. calls of external routine (fbsvcmgr) with opening it in separate command window,
see: subprocess.call('start /min cmd /c ...', shell=True).
2) It was encountered that launching trace session by FBSVCMGR requires 1-2 seconds to be finished,
so this test intentionally uses delay (see calls `time.sleep()`).
3) Format of `database` section differ in 2.5 vs 3.0, so two separate sections have been created here for each FB version.
4) Correct work was checked on: WI-V2.5.5.26914 (SS, SC) and WI-V3.0.0.31940 (SS, SC and CS).

=>

Test Specifics: [Platform (Windows/Linux) specific] =>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants