New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AV in engine when preparing query against dropping table [CORE3557] #3913
Comments
Commented by: @hvlad To reproduce: 1. Prepare database and disconnect firebird\bin>isql 2. First session: drop table and do not commit transaction 3. Second session: run query against dropping table Statement failed, SQLSTATE = 08006 Firebird crashed |
Commented by: @hvlad Another test case (requires FB 2.5 or higher) 1. 2. Statement failed, SQLSTATE = 08006 |
Modified by: @hvladassignee: Vlad Khorsun [ hvlad ] |
Modified by: @hvladstatus: Open [ 1 ] => Resolved [ 5 ] resolution: Fixed [ 1 ] Fix Version: 2.5.1 [ 10333 ] Fix Version: 3.0 Alpha 1 [ 10331 ] Fix Version: 2.0.7 [ 10390 ] Fix Version: 2.1.5 [ 10420 ] |
Commented by: @samofatov The bugfix makes it impossible to drop certain tables with computed fields. Test case was sent privately to Vlad Horsun. I believe this bugfix also is the cause of CORE3579 regression. The reason of the problem is that Vlad's code calls MET_scan_relation when relation fields are already deleted. |
Commented by: @hvlad Additional fix is committed. Please check and confirm if it is ok. |
Commented by: @dmitry-starodubov New fix solves the problem. Thank you. |
Modified by: @hvladstatus: Reopened [ 4 ] => Resolved [ 5 ] resolution: Fixed [ 1 ] Fix Version: 2.5.2 [ 10450 ] Fix Version: 2.5.1 [ 10333 ] => |
Commented by: @dyemanov A new regression is found because of this change. Simple test case: create view v as -- reconnect alter view v as -- no commit here drop view v; -- the engine crashes When MET_scan_relation() is called during DROP, we have the new field list and view BLR out of sync with the RDB$RUNTIME which is modified at the commit time only and thus preserving the original structure. |
Commented by: @pavel-zotov Today isql produced coredump with some of scripts that performed "bulk update" of metadata. HTH |
Modified by: @pavel-zotovAttachment: core_isql.zip [ 12132 ] |
Commented by: @pavel-zotov Another sample: DDL: Then let's try to drop both view and procedure using common script: set autoddl off; create or alter view v as select The message about dependencies appear instead of successful deletion: If we change the view: create or alter view v as -- no errors occured. |
Modified by: @pcisarstatus: Resolved [ 5 ] => Closed [ 6 ] |
Submitted by: @hvlad
Block progress on CORE3579
Attachments:
core_isql.zip
Commits: 0aede9b ed6d43f 34e13e6 13c6c85 7833f5e 0ed1fad d760408 6522004 f414686 ea661b3 757ea1e
The text was updated successfully, but these errors were encountered: