Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More detail in message "wrong page type" [CORE3588] #3942

Closed
firebird-automations opened this issue Aug 29, 2011 · 7 comments
Closed

More detail in message "wrong page type" [CORE3588] #3942

firebird-automations opened this issue Aug 29, 2011 · 7 comments

Comments

@firebird-automations
Copy link
Collaborator

Submitted by: Ann Harrison (awharrison)

Twenty years ago, concise error messages made some sense, but diagnosing the wrong page type errors would be much easier if Firebird said "expected Index Page, encountered Data Page" rather than "expected <n> encountered <m>" - at least it would save me looking up the page types each time. Probably not worth much since those errors are mostly found in older versions, but still, if one realized that something that should have been an index page was something else, then there would be a clue that the workaround would be to rebuild the index. Hey, maybe even include the name of the index and table...

Commits: 64a89b7

@firebird-automations
Copy link
Collaborator Author

Commented by: @aafemt

If page type has unexpected value, who knows what else is damaged. If the page is completely filled with garbage, attempt to resolve value like 123 into page type will cause crash in absence of additional check.

@firebird-automations
Copy link
Collaborator Author

Commented by: Ann Harrison (awharrison)

Yes, it would be wise to have a choice for "unknown page type." sorry I wasn't more specific.

@firebird-automations
Copy link
Collaborator Author

Modified by: @AlexPeshkoff

assignee: Alexander Peshkov [ alexpeshkoff ]

@firebird-automations
Copy link
Collaborator Author

Modified by: @AlexPeshkoff

status: Open [ 1 ] => Open [ 1 ]

Target: 3.0 Beta 1 [ 10332 ]

Implementation: [Trivial]

@firebird-automations
Copy link
Collaborator Author

Modified by: @AlexPeshkoff

status: Open [ 1 ] => Resolved [ 5 ]

resolution: Fixed [ 1 ]

Fix Version: 3.0 Alpha 1 [ 10331 ]

@firebird-automations
Copy link
Collaborator Author

Modified by: @pcisar

status: Resolved [ 5 ] => Closed [ 6 ]

@firebird-automations
Copy link
Collaborator Author

Modified by: @pavel-zotov

QA Status: No test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants