Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Client library cannot connect to the non-ASCII host name [CORE3596] #3950

Closed
firebird-automations opened this issue Sep 13, 2011 · 13 comments
Closed

Comments

@firebird-automations
Copy link
Collaborator

Submitted by: @dyemanov

Attachments:
interface.patch

Since v2.5.0 the connection string is converted into UTF8 in the Y-valve, prior to calling the providers that are expected to convert it back into the system charset if required. But it doesn't happen for the host name in the remote provider (interface.cpp) causing the connection attempt to fail.

Commits: 6876e68 4d05060

@firebird-automations
Copy link
Collaborator Author

Modified by: @dyemanov

assignee: Adriano dos Santos Fernandes [ asfernandes ]

@firebird-automations
Copy link
Collaborator Author

Commented by: @dyemanov

A simple patch that seems to fix the issue is attached, but I'm not sure it's correct for the all possible cases.

@firebird-automations
Copy link
Collaborator Author

Modified by: @dyemanov

Attachment: interface.patch [ 12066 ]

@firebird-automations
Copy link
Collaborator Author

Commented by: @asfernandes

I don't see a problem, but unfortunately I currently have no prepared Windows environment to build and test Firebird.

@firebird-automations
Copy link
Collaborator Author

Commented by: @aafemt

A problem will definitely appear if system charset doesn't include all required symbols. I don't know if unicode version of gethostbyname exists...

@firebird-automations
Copy link
Collaborator Author

Commented by: @dyemanov

Dimitry, provided that system->UTF8->system transformation is peformed on the same host (in fbclient), how could it be possible?

@firebird-automations
Copy link
Collaborator Author

Modified by: @asfernandes

status: Open [ 1 ] => Resolved [ 5 ]

resolution: Fixed [ 1 ]

Fix Version: 3.0 Alpha 1 [ 10331 ]

@firebird-automations
Copy link
Collaborator Author

Modified by: @pavel-zotov

QA Status: No test

@firebird-automations
Copy link
Collaborator Author

Modified by: @pavel-zotov

status: Resolved [ 5 ] => Resolved [ 5 ]

QA Status: No test => Cannot be tested

@firebird-automations
Copy link
Collaborator Author

Commented by: Paolo Salvan (psalvan)

We are using FB 2.5.7 and a lot of our software users are having connection problem because their server has non-ascii characters in the name.

Will this patch be backported to FB 2.5.8?

@firebird-automations
Copy link
Collaborator Author

Commented by: @dyemanov

Paolo, I will check what was actually committed into v3.0 and plan a backport, if it appears possible.

@firebird-automations
Copy link
Collaborator Author

Commented by: @dyemanov

Backported to v2.5.8.

@firebird-automations
Copy link
Collaborator Author

Modified by: @dyemanov

Fix Version: 2.5.8 [ 10809 ]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment