Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Impossible to enter certain characters in isql [CORE362] #702

Closed
firebird-automations opened this issue Oct 3, 2004 · 17 comments
Closed

Comments

@firebird-automations
Copy link
Collaborator

Submitted by: unoengborg (unoengborg)

Assigned to: Frank Schlottmann-Goedde (fsg)

Votes: 1

SFID: 1039201#⁠
Submitted By: unoengborg

I can't input Swedish characters ???????????? at the isql
command line. When I press the key nothing happens and
the cursor remain in the same place.

I run ISQL on Linux (Fedora 2)
ISQL Version: LI-V1.5.1.4481 Firebird 1.5

My LANG environment variable is set to sv_SE.UTF-8

If I do a select that returns tuples containing ???????????? they
display just fine. So the bug only seam to affect input.

@firebird-automations
Copy link
Collaborator Author

Commented by: @mkubecek

This is a known issue of editline library which isql uses for line editing: editline does not work correctly with UTF-8. There are two ways to solve the problem: either fix editline or use another library. Unfortunately the best replacement (readline) is unusable because of its license (GPL).

@firebird-automations
Copy link
Collaborator Author

Commented by: @pmakowski

As this bug is not fixed, you can use, under isql , the EDIT command
by default it call Vi, and there you can input any characters you wanted

@firebird-automations
Copy link
Collaborator Author

Modified by: @pcisar

Workflow: jira [ 10386 ] => Firebird [ 14644 ]

@firebird-automations
Copy link
Collaborator Author

Commented by: @mariuz

In debian/ubuntu we use libedit under bsd licence
i think it can replace the old editline
http://packages.debian.org/sid/libedit-dev
http://packages.qa.debian.org/libe/libedit.html

I will check if it supports UTF-8

@firebird-automations
Copy link
Collaborator Author

Modified by: Frank Schlottmann-Goedde (fsg)

assignee: Frank Schlottmann-Goedde [ fsg ]

@firebird-automations
Copy link
Collaborator Author

Commented by: Frank Schlottmann-Goedde (fsg)

I found an editline replacement (http://www.thrysoee.dk/editline/ ) that handles unicode characters correctly, and meanwhile have an isql working with vi-keymaps. I still need to rework the emacs maps or even create a new mapping to ease line editing a bit. But it's on its way.

@firebird-automations
Copy link
Collaborator Author

Commented by: @pmakowski

good, yes it is what is packaged in most Linux distro
Fedora : http://pkgs.fedoraproject.org/gitweb/?p=libedit.git;a=summary
Mageia : http://svnweb.mageia.org/packages/cauldron/libedit/
...

@firebird-automations
Copy link
Collaborator Author

Commented by: Frank Schlottmann-Goedde (fsg)

Yes, but unfortunately it doesn't work out of the box. It has to be patched at several places to get it to display unicode characters correctly in vi-mode, and it doesn't support them in emacs-mode at all.

@firebird-automations
Copy link
Collaborator Author

Modified by: Frank Schlottmann-Goedde (fsg)

status: Open [ 1 ] => In Progress [ 3 ]

@firebird-automations
Copy link
Collaborator Author

Commented by: @AlexPeshkoff

I've replaced in trunk editline with version, suggested by Frank. Please make sure that this works, if yes - close this ticket please.

@firebird-automations
Copy link
Collaborator Author

Commented by: Frank Schlottmann-Goedde (fsg)

I'll check it as soon as possible, thank you.

@firebird-automations
Copy link
Collaborator Author

Commented by: Frank Schlottmann-Goedde (fsg)

I have checked in the last missing bits to enable UTF8 support for isql and editline.

@firebird-automations
Copy link
Collaborator Author

Commented by: Frank Schlottmann-Goedde (fsg)

fixed with
https://sourceforge.net/p/firebird/code/58550/

@firebird-automations
Copy link
Collaborator Author

Modified by: Frank Schlottmann-Goedde (fsg)

status: In Progress [ 3 ] => Resolved [ 5 ]

resolution: Fixed [ 1 ]

Fix Version: 3.0 Alpha 2 [ 10560 ]

@firebird-automations
Copy link
Collaborator Author

Modified by: @pcisar

status: Resolved [ 5 ] => Closed [ 6 ]

@firebird-automations
Copy link
Collaborator Author

Modified by: @pavel-zotov

QA Status: No test

@firebird-automations
Copy link
Collaborator Author

Modified by: @pavel-zotov

status: Closed [ 6 ] => Closed [ 6 ]

QA Status: No test => Cannot be tested

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant