Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TRACE: replace default value for time_threshold with 0 rather than 100 [CORE3676] #4026

Open
firebird-automations opened this issue Nov 27, 2011 · 1 comment

Comments

@firebird-automations
Copy link
Collaborator

Submitted by: @pavel-zotov

The value of time_threshold = 100 often brings hardly analyzed results in case of many 'lightweight' queries.
For instance, most of all requests of replication system (in case of proper configuration) will not be logged with threshold more than 30-40 ms.
I think that if someone turned trace on, all enabled events should be logged until time threshold is explicitly set to some non-zero value.

@firebird-automations
Copy link
Collaborator Author

Commented by: Sean Leyne (seanleyne)

Your request assumes that the Trace functionality is expected to be used as an "audit" of all database operations. Although this is one possible use of the function, it is an exceptional mode for most installs.

Someone looking to use the Trace should inform themselves about how it should be configured. For them to "assume" that all events will be logged is an un-informed method of operation.

Just as you have suggested that the threshold should be 0, it would be reasonable for someone to complain that the default setting generates too many entries/ too much detail... so, no default value will satisfy all users. Personally, I would be looking for a default of 5 sec since I would be looking for long running queries.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant