Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert password/user name into UTF-8 before encryption [CORE3782] #4125

Closed
firebird-automations opened this issue Mar 1, 2012 · 17 comments
Closed

Comments

@firebird-automations
Copy link
Collaborator

Submitted by: @aafemt

Is related to CORE2929
Duplicates CORE4854
Relate to CORE4863
Relate to CORE3717

Votes: 2

Convert password/user name into UTF-8 before encryption to allow safety using of non-ascii symbols in environments with different locales.

There is one problem, though: isql executing script with encoding different from current locale.

Commits: a89f9b7

@firebird-automations
Copy link
Collaborator Author

Modified by: @AlexPeshkoff

assignee: Alexander Peshkov [ alexpeshkoff ]

@firebird-automations
Copy link
Collaborator Author

Modified by: @AlexPeshkoff

Link: This issue is related to CORE2929 [ CORE2929 ]

@firebird-automations
Copy link
Collaborator Author

Commented by: @AlexPeshkoff

We already had to rollback related issue. Looks like we should make all changes only for FB3 protocol, leaving old connections in peace.

@firebird-automations
Copy link
Collaborator Author

Commented by: @AlexPeshkoff

Dmitry, have you checked - how does trunk behave now regarding national passwords ?

@firebird-automations
Copy link
Collaborator Author

Commented by: @aafemt

No, not yet. Because of WinXP console issues, it may be a bit difficult. I believe you can test it yourself, feeding to isql scripts in different encodings.

@firebird-automations
Copy link
Collaborator Author

Modified by: @AlexPeshkoff

Link: This issue duplicates CORE4854 [ CORE4854 ]

@firebird-automations
Copy link
Collaborator Author

Commented by: @AlexPeshkoff

According to the tests, performed by Pavel Zotov when checking 4854, non-ascii passwords do work correctly in the following environments:
- in any Linux configuration,
- in Windows in GUI tasks,
- in Windows in text console provided ANSI codepage is used.

Due to the fact that input parameters are passed by VisualC to argc/argv always in ANSI codepage (even when current console is using OEM one) passing intl passwords to all utilities in command line does work. The 2 remaining problematic cases are:
- typing password in "connect"/"create database" commands in isql,
- typing password when it's input from terminal is requested in utility switches.

Guessing what codepage is used in scripts, passed to isql, is in general case impossible and is not RDBMS related thing.

@firebird-automations
Copy link
Collaborator Author

Modified by: @AlexPeshkoff

Link: This issue block progress on CORE4863 [ CORE4863 ]

@firebird-automations
Copy link
Collaborator Author

Modified by: @AlexPeshkoff

Link: This issue block progress on CORE4863 [ CORE4863 ] =>

@firebird-automations
Copy link
Collaborator Author

Modified by: @AlexPeshkoff

Link: This issue relate to CORE4863 [ CORE4863 ]

@firebird-automations
Copy link
Collaborator Author

Modified by: @AlexPeshkoff

status: Open [ 1 ] => Resolved [ 5 ]

resolution: Fixed [ 1 ]

Fix Version: 3.0 RC 1 [ 10584 ]

@firebird-automations
Copy link
Collaborator Author

Modified by: @AlexPeshkoff

Link: This issue relate to CORE3717 [ CORE3717 ]

@firebird-automations
Copy link
Collaborator Author

Modified by: @dyemanov

summary: Password encoding => Convert password/user name into UTF-8 before encryption

@firebird-automations
Copy link
Collaborator Author

Commented by: @helebor

So - what exactly was done for RC1?

@firebird-automations
Copy link
Collaborator Author

Modified by: @pcisar

status: Resolved [ 5 ] => Closed [ 6 ]

@firebird-automations
Copy link
Collaborator Author

Modified by: @pavel-zotov

status: Closed [ 6 ] => Closed [ 6 ]

QA Status: No test

@firebird-automations
Copy link
Collaborator Author

Modified by: @pavel-zotov

status: Closed [ 6 ] => Closed [ 6 ]

QA Status: No test => Cannot be tested

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants