New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert password/user name into UTF-8 before encryption [CORE3782] #4125
Comments
Modified by: @AlexPeshkoffassignee: Alexander Peshkov [ alexpeshkoff ] |
Modified by: @AlexPeshkoff |
Commented by: @AlexPeshkoff We already had to rollback related issue. Looks like we should make all changes only for FB3 protocol, leaving old connections in peace. |
Commented by: @AlexPeshkoff Dmitry, have you checked - how does trunk behave now regarding national passwords ? |
Commented by: @aafemt No, not yet. Because of WinXP console issues, it may be a bit difficult. I believe you can test it yourself, feeding to isql scripts in different encodings. |
Modified by: @AlexPeshkoff |
Commented by: @AlexPeshkoff According to the tests, performed by Pavel Zotov when checking 4854, non-ascii passwords do work correctly in the following environments: Due to the fact that input parameters are passed by VisualC to argc/argv always in ANSI codepage (even when current console is using OEM one) passing intl passwords to all utilities in command line does work. The 2 remaining problematic cases are: Guessing what codepage is used in scripts, passed to isql, is in general case impossible and is not RDBMS related thing. |
Modified by: @AlexPeshkoff |
Modified by: @AlexPeshkoff |
Modified by: @AlexPeshkoff |
Modified by: @AlexPeshkoffstatus: Open [ 1 ] => Resolved [ 5 ] resolution: Fixed [ 1 ] Fix Version: 3.0 RC 1 [ 10584 ] |
Modified by: @AlexPeshkoff |
Modified by: @dyemanovsummary: Password encoding => Convert password/user name into UTF-8 before encryption |
Commented by: @helebor So - what exactly was done for RC1? |
Modified by: @pcisarstatus: Resolved [ 5 ] => Closed [ 6 ] |
Modified by: @pavel-zotovstatus: Closed [ 6 ] => Closed [ 6 ] QA Status: No test => Cannot be tested |
Submitted by: @aafemt
Is related to CORE2929
Duplicates CORE4854
Relate to CORE4863
Relate to CORE3717
Votes: 2
Convert password/user name into UTF-8 before encryption to allow safety using of non-ascii symbols in environments with different locales.
There is one problem, though: isql executing script with encoding different from current locale.
Commits: a89f9b7
The text was updated successfully, but these errors were encountered: