Issue Details (XML | Word | Printable)

Key: CORE-3875
Type: Bug Bug
Status: Closed Closed
Resolution: Fixed
Priority: Minor Minor
Assignee: Alexander Peshkov
Reporter: Semi
Votes: 0
Watchers: 2
Operations

If you were logged in you would be able to see more operations.
Firebird Core

GBak does not check correctly parameters and backups random database with -B ":"

Created: 22/Jun/12 06:07 PM   Updated: 23/Apr/13 01:56 PM
Component/s: GBAK
Affects Version/s: 2.0.5
Fix Version/s: 2.5.2, 3.0 Alpha 1, 2.1.6

Time Tracking:
Not Specified

Environment: Windows XP SP2, Firebird 2.0.4

Planning Status: Unspecified


 Description  « Hide
Given command:
"C:\Program Files\Firebird\Firebird_2_0\bin\gbak.exe" -T -B ":" "C:\Backup\BackupFileName.FBK" -v
the gbak 2.0.4 picks up some database for backup instead of giving error report.

Having this as a daily backup (due to batch error), it picked up different databases on different days...

Usual output is:
gbak: ERROR:file is not a valid database
gbak:Exiting before completion due to errors

Sometimes it writes:
gbak: ERROR:I/O error for file "MyDatabaseName
?"
gbak: ERROR: Error while trying to open file

(where the ? is char #04)

In cca 1/10 cases it had backed up some database...
It probably happens only, if another program has a database opened...? It also backed up the database after some time the last program, that had it opened, has terminated... (as detected from my logs)

Test batch:

@echo off

:retry

"C:\Program Files\Firebird\Firebird_2_0\bin\gbak.exe" -T -B ":" "C:\Backup\test.fbk" -v
if errorlevel 1 goto retry


During running this batch, other program starting or terminating sometimes triggers this...
Using -B "localhost:" also sometimes triggers this error...


 All   Comments   Work Log   Change History   Version Control   Subversion Commits      Sort Order: Ascending order - Click to sort in descending order
Alexander Peshkov added a comment - 27/Jun/12 11:01 AM
I do not see how this can affect windows builds, but that probably requires more checks

Alexander Peshkov added a comment - 27/Jun/12 11:02 AM
Semi, please try (after 2 or days) with snapshot build of 2.1 or 2.5 to make sure did I fix your problem completely.

Simonov Denis added a comment - 27/Jun/12 05:19 PM
Fix Version/s: 3.0 Alpha 1, 2.5.3, 2.1.6
Why not 2.5.2?

Sean Leyne added a comment - 27/Jun/12 05:26 PM
v2.5.2 has already reach the RC stage, no new bug fixes should be added now.

Dmitry Yemanov added a comment - 27/Jun/12 05:31 PM
Sean, 2.5.2 is not at RC yet, although very close. And technically speaking, Alex has committed the patch into v2.5.2, as this version does not have a tag fork yet. So it will be available in v2.5.2.

Sean Leyne added a comment - 27/Jun/12 05:34 PM
Obviously, I stand corrected.

Dmitry Yemanov added a comment - 11/Sep/12 02:51 PM
Alex, shouldn't we resolve this ticket?

Alexander Peshkov added a comment - 12/Sep/12 05:56 AM
I was waiting for people to check it on windows. If it's OK - resolve it please.