Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GSEC couldn't change user password after fix for CORE-3981 [CORE3986] #4318

Closed
firebird-automations opened this issue Nov 16, 2012 · 12 comments

Comments

@firebird-automations
Copy link
Collaborator

Submitted by: @dmitry-starodubov

Is related to CORE3981

bin>gsec -user sysdba -pas masterkey -add test -pw test

bin>gsec -user sysdba -pas masterkey -mod test -pw test
An error occurred while attempting to modify the user record.
attempted update of read-only column

Commits: 60d8b9f 88bdceb

@firebird-automations
Copy link
Collaborator Author

Modified by: @dyemanov

assignee: Dmitry Yemanov [ dimitr ]

@firebird-automations
Copy link
Collaborator Author

Modified by: @dyemanov

Link: This issue is related to CORE3981 [ CORE3981 ]

@firebird-automations
Copy link
Collaborator Author

Commented by: @dyemanov

This patch cures the issue, but I'm not 100% sure in its correctness. I'd welcome any additional review.

@firebird-automations
Copy link
Collaborator Author

Modified by: @dyemanov

Attachment: core-3986.patch [ 12263 ]

@firebird-automations
Copy link
Collaborator Author

Commented by: @asfernandes

I'm not an expert on this part of the code, but, I don't understood why delete uses a parent_stream = 1 while store calls pass1_update (the first time) passing 0 (parent_stream).

@firebird-automations
Copy link
Collaborator Author

Commented by: @dmitry-starodubov

It seems this patch fixes the problem. At least GSEC works again and QM tests performed without unexpected errors.

@firebird-automations
Copy link
Collaborator Author

Commented by: @dyemanov

Besides the problems with deletes from updateable views mentioned by Adriano, I've found other issues with the original fix that are not addressed by the attached patch. So I'm investigating other solutions for the problem.

@firebird-automations
Copy link
Collaborator Author

Modified by: @dyemanov

Attachment: core-3986.patch [ 12263 ] =>

@firebird-automations
Copy link
Collaborator Author

Commented by: @dyemanov

I've committed what I consider being a better patch. I don't assign a target version number as it's a snapshot only issue and it should not be included into the release notes for v2.5.3.

@firebird-automations
Copy link
Collaborator Author

Modified by: @dyemanov

status: Open [ 1 ] => Resolved [ 5 ]

resolution: Fixed [ 1 ]

@firebird-automations
Copy link
Collaborator Author

Modified by: @pcisar

status: Resolved [ 5 ] => Closed [ 6 ]

@firebird-automations
Copy link
Collaborator Author

Modified by: @pavel-zotov

status: Closed [ 6 ] => Closed [ 6 ]

QA Status: No test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants