Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jrd/exe.cpp - build failure [CORE4066] #4394

Closed
firebird-automations opened this issue Mar 18, 2013 · 8 comments
Closed

jrd/exe.cpp - build failure [CORE4066] #4394

firebird-automations opened this issue Mar 18, 2013 · 8 comments

Comments

@firebird-automations
Copy link
Collaborator

Submitted by: Treeve Jelbert (treeve)

g++ -DFB_SEND_FLAGS=MSG_NOSIGNAL -DLINUX -DAMD64 -pipe -MMD -fPIC -fmessage-length=0 -O3 -fno-omit-frame-pointer -I/var/git/x86_64/firebird3/src/include/gen -I/var/git/x86_64/firebird3/src/include -fno-rtti -march=native -mtune=native -m64 -pipe -ffast-math -funroll-loops -O3 -c /var/git/x86_64/firebird3/src/jrd/exe.cpp -o /var/git/x86_64/firebird3/temp/Release/jrd/exe.o
/var/git/x86_64/firebird3/src/jrd/exe.cpp: In function 'void EXE_execute_triggers(Jrd::thread_db*, Jrd::trig_vec**, Jrd::record_param*, Jrd::record_param*, Jrd::jrd_req::req_ta, Jrd::StmtNode::WhichTrigger)':
/var/git/x86_64/firebird3/src/jrd/exe.cpp:1115:59: error: operands to ?: have different types 'Jrd::Record* const' and 'Firebird::AutoPtrJrd::Record\'
/var/git/x86_64/firebird3/src/jrd/exe.cpp:1127:59: error: operands to ?: have different types 'Jrd::Record* const' and 'Firebird::AutoPtrJrd::Record\'
make[3]: *** [/var/git/x86_64/firebird3/temp/Release/jrd/exe.o] Error 1

this is svn revision 57799

everything built ok a few days ago

Commits: a2dd7e2

@firebird-automations
Copy link
Collaborator Author

Commented by: @dyemanov

I fail to see why GCC ignores a built-in conversion operator here. Does something like this work:

trigger->req_rpb[0].rpb_record = old_rec ? old_rec : (Record*) null_rec;
and
trigger->req_rpb[1].rpb_record = new_rec ? new_rec : (Record*) null_rec;

?

@firebird-automations
Copy link
Collaborator Author

Commented by: @AlexPeshkoff

Thank's for reporting, but do not think that pre-alpha trunk is worth a ticket for each compiler failure...

@firebird-automations
Copy link
Collaborator Author

Modified by: @AlexPeshkoff

status: Open [ 1 ] => Resolved [ 5 ]

resolution: Fixed [ 1 ]

Fix Version: 3.0 Alpha 1 [ 10331 ]

@firebird-automations
Copy link
Collaborator Author

Commented by: Treeve Jelbert (treeve)

the suggested change compiles ok

@firebird-automations
Copy link
Collaborator Author

Commented by: @AlexPeshkoff

I also do not understand why conversion operator is igored here. But must say it does not work in g++ in other similiar cases.

@firebird-automations
Copy link
Collaborator Author

Modified by: @dyemanov

Version: 3.0 Initial [ 10301 ]

Version: 3.0.0 [ 10048 ] =>

@firebird-automations
Copy link
Collaborator Author

Modified by: @pcisar

status: Resolved [ 5 ] => Closed [ 6 ]

@firebird-automations
Copy link
Collaborator Author

Modified by: @pavel-zotov

status: Closed [ 6 ] => Closed [ 6 ]

QA Status: Cannot be tested

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant