Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FB 2.5 Windows installer doesn't detect existing FB 2.1 install [CORE4110] #4438

Open
firebird-automations opened this issue May 31, 2013 · 1 comment

Comments

@firebird-automations
Copy link
Collaborator

Submitted by: michalk1 (michalk1)

The FB 2.5 Windows installer doesn't detect existing FB 2.1 install and as a result, overwrites it's service settings.

Steps to reproduce:
- Install Firebird 2.1.5, default settings
- Stop the Firebird service
- Install Firebird 2.5.2, default settings
Now, the only installed service is the FB 2.5 one.

The correct behaviour should be to show a warning message: "If you continue with this installation Firebird will be installed but not configured".

The bug is probably in the following fragment of AnalysisAssessment function in file FirebirdInstall_20.iss, which was left unmodified since FB 2.1 (another resembling suspicious code is in SummarizeInstalledProducts function):

function AnalysisAssessment: boolean;
...
//If existing install of the same majorver.minorver is
//found then we can upgrade it.
if ( (ProductsInstalledCount = 1) AND
#⁠if PlatformTarget == "x64"
((ProductsInstalled AND FB21_x64 ) = FB21_x64 ) ) then begin
#⁠else
((ProductsInstalled AND FB21 ) = FB21 ) ) then begin
#⁠endif
result := true;
exit;
end
;
...

Commits: 26f5fe4

@firebird-automations
Copy link
Collaborator Author

Modified by: @reevespaul

assignee: Paul Reeves [ paul_reeves ]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants