Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metadata source becomes wrong after twice transliteration to the metadata charset. [CORE4119] #4447

Closed
firebird-automations opened this issue Jun 16, 2013 · 10 comments

Comments

@firebird-automations
Copy link
Collaborator

Submitted by: @sim1984

In compilation time of stored procedures not ASCII characters are distorted

c:\Program Files\Firebird\Firebird_3_0>isql
Use CONNECT or CREATE DATABASE to specify a database
SQL> set names win1251;
SQL> create database 'localhost/3051:d:\interbasedata\3.0\test.fdb' user 'sysdba' password 'masterkey' default character set win1251;
SQL> set term ^;
SQL> create procedure myproc
CON> as
CON> begin
CON> -- Моя процедура
CON> end^
SQL> set term ;^
SQL> show procedure myproc;
Procedure text:

begin
-- Р?ВRРї Р+Р°ВRР¶Т?В¤Р?а 
end

Version 2.5.2 work is correct

Commits: 60d0269 FirebirdSQL/fbt-repository@a08081e

@firebird-automations
Copy link
Collaborator Author

Modified by: @sim1984

environment: Firebird 3.0.0.30435

@firebird-automations
Copy link
Collaborator Author

Commented by: @asfernandes

What's the client OS?

@firebird-automations
Copy link
Collaborator Author

Commented by: @sim1984

Windows 7 x86.
Firebird 2.5.2 work is correct.

@firebird-automations
Copy link
Collaborator Author

Modified by: @sim1984

environment: Firebird 3.0.0.30435 => Firebird 3.0.0.30435, Windows 7 x86

summary: In compilation time of stored procedures not ASCII characters are distorted => Regression: In compilation time of stored procedures not ASCII characters are distorted

@firebird-automations
Copy link
Collaborator Author

Commented by: @dyemanov

Double transliteration happens:
- prepareStatement() converts from the attachment charset to utf8
- storeMetaDataBlob() thinks that input is in the attachment charset and converts it once more

As a result, a non-decodable string is stored in the system table.

@firebird-automations
Copy link
Collaborator Author

Modified by: @dyemanov

assignee: Adriano dos Santos Fernandes [ asfernandes ]

@firebird-automations
Copy link
Collaborator Author

Modified by: @asfernandes

Fix Version: 3.0 Alpha 1 [ 10331 ]

summary: Regression: In compilation time of stored procedures not ASCII characters are distorted => Metadata source becomes wrong after twice transliteration to the metadata charset.

@firebird-automations
Copy link
Collaborator Author

Modified by: @asfernandes

status: Open [ 1 ] => Resolved [ 5 ]

resolution: Fixed [ 1 ]

@firebird-automations
Copy link
Collaborator Author

Modified by: @pcisar

status: Resolved [ 5 ] => Closed [ 6 ]

@firebird-automations
Copy link
Collaborator Author

Modified by: @pavel-zotov

status: Closed [ 6 ] => Closed [ 6 ]

QA Status: Done successfully

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants