New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New API should return proper metadata properties, not the historical artifacts [CORE4178] #4504
Comments
Modified by: @AlexPeshkoffassignee: Alexander Peshkov [ alexpeshkoff ] |
Modified by: @dyemanovFix Version: 3.0 Beta 1 [ 10332 ] |
Modified by: @AlexPeshkoffstatus: Open [ 1 ] => In Progress [ 3 ] |
Commented by: @AlexPeshkoff Database with a table with various fields and a program to display metadata properties for them |
Modified by: @AlexPeshkoffAttachment: test4178.sql [ 12389 ] |
Modified by: @AlexPeshkoffstatus: In Progress [ 3 ] => Resolved [ 5 ] resolution: Fixed [ 1 ] Fix Version: 3.0 Alpha 2 [ 10560 ] Fix Version: 3.0 Beta 1 [ 10332 ] => |
Modified by: @pcisarstatus: Resolved [ 5 ] => Closed [ 6 ] |
Submitted by: @dyemanov
Attachments:
t4178.cpp
test4178.sql
test4178.sql
Instead of returning implementation details and keeing the old API weirdness, let's provide a clear implementation in IMessageMetadata. Now, for SQL_BLOB (subtype TEXT), getScale() returns a charset. For SQL_VARYING, getSubType() returns a charset, getCharSet() returns zero (accordingly to user reports). This makes the interface hardly usable and plays against the long-term success of the new API.
The fact that the old API emulation is stacked on top of the new API (thus possibly requiring a conversion between proper and legacy property values) could be a problem here, but it must be solved.
Commits: 2ab67b5 FirebirdSQL/fbt-repository@cf28250
The text was updated successfully, but these errors were encountered: