New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Preserve comments for output parameters after altering procedures [CORE4210] #4535
Comments
Modified by: @asfernandesassignee: Adriano dos Santos Fernandes [ asfernandes ] |
Commented by: @asfernandes Cannot reproduce: SQL> create or alter procedure p1 (i integer) returns (o integer) as begin end; |
Commented by: Vladimir Arkhipov (arkinform) The problem is reproduced when I use domains or type of column for parameters. |
Commented by: @asfernandes What I see is this, when an input parameter is changed to output, the comment is lost: SQL> alter procedure p1 (o integer) returns (i integer) as begin end; |
Commented by: @asfernandes I found problem in 2.5, but are you sure there is still problem in v3-alpha1? If yes, please send a valid test case. |
Commented by: Vladimir Arkhipov (arkinform) Sorry, I did not test it again on Firebird 3.0 Alpha 1, remove this version from issue. |
Commented by: @asfernandes Please test the fix in the next 2.5 snapshot build. |
Modified by: @asfernandesstatus: Open [ 1 ] => Resolved [ 5 ] resolution: Fixed [ 1 ] Fix Version: 2.5.3 [ 10461 ] |
Modified by: @asfernandesVersion: 3.0 Alpha 1 [ 10331 ] => |
Commented by: Vladimir Arkhipov (arkinform) Works fine, thank you. |
Modified by: @pavel-zotovstatus: Resolved [ 5 ] => Resolved [ 5 ] QA Status: Done successfully Test Details: Confirmed for 2.5.0...2.5.2: lost comments for some arguments. |
Submitted by: Vladimir Arkhipov (arkinform)
Is related to QA607
Сontinuation of CORE3140. After fixing does not work for output parameters. For input parameters description is preserved.
Commits: 58804e7 FirebirdSQL/fbt-repository@a31da6b
====== Test Details ======
Confirmed for 2.5.0...2.5.2: lost comments for some arguments.
The text was updated successfully, but these errors were encountered: