Issue Details (XML | Word | Printable)

Key: CORE-4259
Type: Bug Bug
Status: Closed Closed
Resolution: Fixed
Priority: Minor Minor
Assignee: Frank Schlottmann-Goedde
Reporter: Dimitry Sibiryakov
Votes: 0
Watchers: 0

If you were logged in you would be able to see more operations.
Firebird Core

Don't call setlocale(LC_CTYPE, "") in isql for Windows

Created: 11/Nov/13 10:48 AM   Updated: 25/May/16 06:21 AM
Component/s: ISQL
Affects Version/s: 3.0 Alpha 1
Fix Version/s: 3.0 Beta 2

Environment: WinXP

QA Status: Cannot be tested

 Description  « Hide
It breaks usual chcp work.

 All   Comments   Change History   Subversion Commits      Sort Order: Ascending order - Click to sort in descending order
Frank Schlottmann-Goedde added a comment - 16/Nov/13 11:50 AM
Fixed with Rev. 58796

Dimitry Sibiryakov added a comment - 16/Nov/13 11:59 AM
This fix is wrong, IMHO.

Proposed fix:
#if !defined(WIN_NT) && (defined(HAVE_EDITLINE_H) || defined(HAVE_LOCALE_H))

Frank Schlottmann-Goedde added a comment - 16/Nov/13 12:58 PM
Should be enough to check for HAVE_EDITLINE_H and HAVE_LOCALE, we don't have editline under Windows.

Dimitry Sibiryakov added a comment - 17/Dec/14 02:48 PM
Someone added another call to setlocale() into ISQL_main() thus resurrecting the bug. Remove it, please.

Dmitry Yemanov added a comment - 17/Dec/14 03:13 PM
"Someone" added setlocale() into ISQL_main() in May 2012 into both v2.5 and 3.0. This ticket was claimed as fixed after that. So it seems that:

- somebody added the second setlocale() into main() after that (only in 3.0)
- then, the second call was disabled for Windows
- then, you didn't (and nobody else did) test this bugfix after resolving