New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't call setlocale(LC_CTYPE, "") in isql for Windows [CORE4259] #4583
Comments
Modified by: Frank Schlottmann-Goedde (fsg)assignee: Frank Schlottmann-Goedde [ fsg ] |
Commented by: Frank Schlottmann-Goedde (fsg) Fixed with Rev. 58796 |
Modified by: Frank Schlottmann-Goedde (fsg)status: Open [ 1 ] => Resolved [ 5 ] resolution: Fixed [ 1 ] Fix Version: 3.0 Alpha 2 [ 10560 ] |
Commented by: @aafemt This fix is wrong, IMHO. Proposed fix: |
Commented by: Frank Schlottmann-Goedde (fsg) Should be enough to check for HAVE_EDITLINE_H and HAVE_LOCALE, we don't have editline under Windows. |
Modified by: @pcisarstatus: Resolved [ 5 ] => Closed [ 6 ] |
Commented by: @aafemt Someone added another call to setlocale() into ISQL_main() thus resurrecting the bug. Remove it, please. |
Modified by: @aafemtstatus: Closed [ 6 ] => Reopened [ 4 ] Fix Version: 3.0 Beta 2 [ 10586 ] resolution: Fixed [ 1 ] => Fix Version: 3.0 Alpha 2 [ 10560 ] => |
Commented by: @dyemanov "Someone" added setlocale() into ISQL_main() in May 2012 into both v2.5 and 3.0. This ticket was claimed as fixed after that. So it seems that: - somebody added the second setlocale() into main() after that (only in 3.0) |
Modified by: @pcisarstatus: Resolved [ 5 ] => Closed [ 6 ] |
Modified by: @pavel-zotovstatus: Closed [ 6 ] => Closed [ 6 ] QA Status: No test => Cannot be tested |
Submitted by: @aafemt
Assigned to: Frank Schlottmann-Goedde (fsg)
It breaks usual chcp work.
Commits: 9f235c2 bb54414 FirebirdSQL/fbt-repository@02b1f1a FirebirdSQL/fbt-repository@64e3530
The text was updated successfully, but these errors were encountered: