Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FB3: WITHDRAWN Delimited identifiers do not work anymore for CREATE/ALTER/DROP TABLE [CORE4282] #4605

Closed
firebird-automations opened this issue Nov 26, 2013 · 6 comments

Comments

@firebird-automations
Copy link
Collaborator

Submitted by: Robert (rjm1102)

Sorry, this is not a bug. I was caused by an invalid DDL trigger I defined myself :(
Please close, or better delete. So sorry.

(WI-T3.0.0.30566 Firebird 3.0 Alpha 1)
[Regression]

Test case 1 ("Table X" is a delimited identifier):

CREATE TABLE "Table X"
(
FieldY INTEGER PRIMARY KEY
)

This result in error on executing:

unsuccessful metadata update
CREATE TABLE Table X failed
expression evaluation not supported

SQL code: -607

Same error for test case 2 ("Field Y" is a delimited identifier):

CREATE TABLE TableX
(
"Field Y" INTEGER PRIMARY KEY
)

Same error for test case 3:
ALTER TABLE TableX ADD "Field Y" INTEGER

Same error for test case 4:
DROP TABLE "Table Z" /* table "Table Z was created under FB2.5 and restored under FB3 */

My first guess is something is broken in the sql parser for FB3 regaring CREATE/ALTER/DROP TABLE.
Under FB2.5 these DDLs work okay.

Note: other DDL statements (like CREATE DOMAIN "Domain X" AS INTEGER), still work fine with delimited identifiers in FB3.

- Robert
NL

@firebird-automations
Copy link
Collaborator Author

Modified by: Robert (rjm1102)

summary: FB#⁠: Delimited identifiers does not work anymore for CREATE/ALTER/DROP TABLE => FB3: Delimited identifiers do not work anymore for CREATE/ALTER/DROP TABLE

@firebird-automations
Copy link
Collaborator Author

Commented by: @asfernandes

What's the database and client dialect?

@firebird-automations
Copy link
Collaborator Author

Modified by: Robert (rjm1102)

description: (WI-T3.0.0.30566 Firebird 3.0 Alpha 1)
[Regression]

Test case 1 ("Table X" is a delimited identifier):

CREATE TABLE "Table X"
(
FieldY INTEGER PRIMARY KEY
)

This result in error on executing:

unsuccessful metadata update
CREATE TABLE Table X failed
expression evaluation not supported

SQL code: -607

Same error for test case 2 ("Field Y" is a delimited identifier):

CREATE TABLE TableX
(
"Field Y" INTEGER PRIMARY KEY
)

Same error for test case 3:
ALTER TABLE TableX ADD "Field Y" INTEGER

Same error for test case 4:
DROP TABLE "Table Z" /* table "Table Z was created under FB2.5 and restored under FB3 */

My first guess is something is broken in the sql parser for FB3 regaring CREATE/ALTER/DROP TABLE.
Under FB2.5 these DDLs work okay.

Note: other DDL statements (like CREATE DOMAIN "Domain X" AS INTEGER), still work fine with delimited identifiers in FB3.

- Robert
NL

=>

Sorry, this is not a bug. I was caused by an invalid DDL trigger I defined myself :(
Please close, or better delete. So sorry.

(WI-T3.0.0.30566 Firebird 3.0 Alpha 1)
[Regression]

Test case 1 ("Table X" is a delimited identifier):

CREATE TABLE "Table X"
(
FieldY INTEGER PRIMARY KEY
)

This result in error on executing:

unsuccessful metadata update
CREATE TABLE Table X failed
expression evaluation not supported

SQL code: -607

Same error for test case 2 ("Field Y" is a delimited identifier):

CREATE TABLE TableX
(
"Field Y" INTEGER PRIMARY KEY
)

Same error for test case 3:
ALTER TABLE TableX ADD "Field Y" INTEGER

Same error for test case 4:
DROP TABLE "Table Z" /* table "Table Z was created under FB2.5 and restored under FB3 */

My first guess is something is broken in the sql parser for FB3 regaring CREATE/ALTER/DROP TABLE.
Under FB2.5 these DDLs work okay.

Note: other DDL statements (like CREATE DOMAIN "Domain X" AS INTEGER), still work fine with delimited identifiers in FB3.

- Robert
NL

summary: FB3: Delimited identifiers do not work anymore for CREATE/ALTER/DROP TABLE => FB3: WITHDRAWN Delimited identifiers do not work anymore for CREATE/ALTER/DROP TABLE

@firebird-automations
Copy link
Collaborator Author

Commented by: @mrotteveel

Robert, it is probably better to communicate things like "Sorry, this is not a bug. I was caused by an invalid DDL trigger I defined myself :(
Please close, or better delete. So sorry. " by adding a comment instead of adding the description: it is more likely to get noticed by people who already read the initial description,

@firebird-automations
Copy link
Collaborator Author

Modified by: Sean Leyne (seanleyne)

status: Open [ 1 ] => Resolved [ 5 ]

resolution: Cannot Reproduce [ 5 ]

@firebird-automations
Copy link
Collaborator Author

Modified by: @pcisar

status: Resolved [ 5 ] => Closed [ 6 ]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant