Issue Details (XML | Word | Printable)

Key: CORE-4297
Type: Bug Bug
Status: Closed Closed
Resolution: Fixed
Priority: Critical Critical
Assignee: Vlad Khorsun
Reporter: Attila Molnár
Votes: 0
Watchers: 4
Operations

If you were logged in you would be able to see more operations.
Firebird Core

Gfix crashed when description of limbo transaction have size large than 1KB

Created: 11/Dec/13 09:46 AM   Updated: 25/May/16 06:24 AM
Component/s: GFIX
Affects Version/s: 2.1.0, 2.1.1, 2.1.2, 2.1.3, 2.5.0, 2.1.4, 2.5.1, 2.1.5, 2.5.2, 2.1.5 Update 1, 2.5.2 Update 1, 3.0 Alpha 1
Fix Version/s: 3.0 Alpha 2, 2.5.3

QA Status: Cannot be tested


 Description  « Hide
Hi!

A DDL command (C/A procedure) was executed in a single transaction in multiple databases, and it faild at commit.
Now reading system table throws limbo error. (This is OK, this is the expected behavior)
BUT, when trying to fix it with gfix it crashes the server.



 All   Comments   Change History   Subversion Commits      Sort Order: Ascending order - Click to sort in descending order
Vlad Khorsun added a comment - 11/Dec/13 10:04 AM
Reproducible example required

Attila Molnár added a comment - 11/Dec/13 10:15 AM
File attached

Vlad Khorsun added a comment - 11/Dec/13 10:46 AM
I see that gfix is crashed but not the server. Can you confirm ?
Also, show gfix command line you use, please.

Attila Molnár added a comment - 11/Dec/13 11:51 AM
My bad. Gfix crashed not Firebird. I just was deceived by MS error reporting window which shown "Firebird SQL Server".

-t all
-r all
-t 104549
-r 104549

Vlad Khorsun added a comment - 11/Dec/13 12:00 PM
Changed description to better reflect bug nature

Sean Leyne added a comment - 11/Dec/13 04:15 PM - edited
@Vlad,

What does transaction "description" refer to?

Vlad Khorsun added a comment - 11/Dec/13 04:29 PM
Contents of RDB$TRANSACTIONS.RDB$TRANSACTION_DESCRIPTION

Every 2PC transaction usually have its description stored in RDB$TRANSACTIONS at every participant database.
It is stored at the 1st phase of two phase commit and allows to recover such transaction after failure.

Vlad Khorsun added a comment - 11/Dec/13 04:37 PM
Atilla,

patch is committed.
Please, confirm it is ok (using tomorrows snapshot build).
It is enough to extract just a gfix.exe, if you don't want to use snapshot build in production.

Attila Molnár added a comment - 13/Dec/13 07:29 AM
Fix is confirmed, it works.
Please delete the attached file.
Thank You!

Vlad Khorsun added a comment - 13/Dec/13 07:39 AM
I have no privileges to delete attachments but i'll ask tracker admins to do it