Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gfix crashed when description of limbo transaction have size large than 1KB [CORE4297] #4620

Closed
firebird-automations opened this issue Dec 11, 2013 · 18 comments

Comments

@firebird-automations
Copy link
Collaborator

Submitted by: Attila Molnár (e_pluribus_unum)

Hi!

A DDL command (C/A procedure) was executed in a single transaction in multiple databases, and it faild at commit.
Now reading system table throws limbo error. (This is OK, this is the expected behavior)
BUT, when trying to fix it with gfix it crashes the server.

Commits: 5554f52 82a1736 FirebirdSQL/fbt-repository@192fd9f FirebirdSQL/fbt-repository@0396389

@firebird-automations
Copy link
Collaborator Author

Commented by: @hvlad

Reproducible example required

@firebird-automations
Copy link
Collaborator Author

Modified by: Attila Molnár (e_pluribus_unum)

Attachment: OMSMO.7z [ 12395 ]

@firebird-automations
Copy link
Collaborator Author

Commented by: Attila Molnár (e_pluribus_unum)

File attached

@firebird-automations
Copy link
Collaborator Author

Commented by: @hvlad

I see that gfix is crashed but not the server. Can you confirm ?
Also, show gfix command line you use, please.

@firebird-automations
Copy link
Collaborator Author

Modified by: @hvlad

assignee: Vlad Khorsun [ hvlad ]

@firebird-automations
Copy link
Collaborator Author

Commented by: Attila Molnár (e_pluribus_unum)

My bad. Gfix crashed not Firebird. I just was deceived by MS error reporting window which shown "Firebird SQL Server".

-t all
-r all
-t 104549
-r 104549

@firebird-automations
Copy link
Collaborator Author

Commented by: @hvlad

Changed description to better reflect bug nature

@firebird-automations
Copy link
Collaborator Author

Modified by: @hvlad

Version: 3.0 Alpha 1 [ 10331 ]

Version: 2.1.5 Update 1 [ 10522 ]

Version: 2.5.2 [ 10450 ]

Version: 2.1.5 [ 10420 ]

Version: 2.5.1 [ 10333 ]

Version: 2.1.4 [ 10361 ]

Version: 2.5.0 [ 10221 ]

Version: 2.1.3 [ 10302 ]

Version: 2.1.2 [ 10270 ]

Version: 2.1.1 [ 10223 ]

Version: 2.1.0 [ 10041 ]

Component: GFIX [ 10004 ]

summary: Firebird server crash when running gfix for fixing limbo transaction => Gfix crashed when description of limbo transaction have size large than 1KB

@firebird-automations
Copy link
Collaborator Author

Commented by: Sean Leyne (seanleyne)

@vlad,

What does transaction "description" refer to?

@firebird-automations
Copy link
Collaborator Author

Commented by: @hvlad

Contents of RDB$TRANSACTIONS.RDB$TRANSACTION_DESCRIPTION

Every 2PC transaction usually have its description stored in RDB$TRANSACTIONS at every participant database.
It is stored at the 1st phase of two phase commit and allows to recover such transaction after failure.

@firebird-automations
Copy link
Collaborator Author

Commented by: @hvlad

Atilla,

patch is committed.
Please, confirm it is ok (using tomorrows snapshot build).
It is enough to extract just a gfix.exe, if you don't want to use snapshot build in production.

@firebird-automations
Copy link
Collaborator Author

Commented by: Attila Molnár (e_pluribus_unum)

Fix is confirmed, it works.
Please delete the attached file.
Thank You!

@firebird-automations
Copy link
Collaborator Author

Commented by: @hvlad

I have no privileges to delete attachments but i'll ask tracker admins to do it

@firebird-automations
Copy link
Collaborator Author

Modified by: @hvlad

status: Open [ 1 ] => Resolved [ 5 ]

resolution: Fixed [ 1 ]

Fix Version: 2.5.3 [ 10461 ]

Fix Version: 3.0 Alpha 2 [ 10560 ]

@firebird-automations
Copy link
Collaborator Author

Modified by: @dyemanov

Attachment: OMSMO.7z [ 12395 ] =>

@firebird-automations
Copy link
Collaborator Author

Modified by: @pcisar

status: Resolved [ 5 ] => Closed [ 6 ]

@firebird-automations
Copy link
Collaborator Author

Modified by: @pavel-zotov

status: Closed [ 6 ] => Closed [ 6 ]

QA Status: No test

@firebird-automations
Copy link
Collaborator Author

Modified by: @pavel-zotov

status: Closed [ 6 ] => Closed [ 6 ]

QA Status: No test => Cannot be tested

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment