Issue Details (XML | Word | Printable)

Key: CORE-4475
Type: Bug Bug
Status: Closed Closed
Resolution: Fixed
Priority: Major Major
Assignee: Alexander Peshkov
Reporter: Lionel Elie Mamane
Votes: 0
Watchers: 2
Operations

If you were logged in you would be able to see more operations.
Firebird Core

after fb_shutdown(), end-of-process cleanup should not do anything

Created: 28/Jun/14 01:33 PM   Updated: 25/May/16 08:09 AM
Component/s: API / Client Library
Affects Version/s: 2.5.2
Fix Version/s: 2.5.4

Environment: MacOS X 10.9, development build of Firebird

QA Status: Cannot be tested


 Description  « Hide
LibreOffice embeds FireBird, telling it to use a subdirectory of the LibreOffice tempdir for the firebird lockdir.

At process shutdown, ~Cleanup from file init.cpp is called, which calls this stack:
allClean()
Firebird::InstanceControl::destructors()
Firebird::InstanceControl::InstanceList::destructors()
Firebird::InstanceControl::InstanceLink<jrd::StorageInstance, ...>::dtor
jrd::StorageInstance::dtor
~ConfigStorage
ISC_remove_map_file(sh_mem const*)
ISC_remove_map_file(char const*)
gds_prefix_lock
os_utils::createLockDirectory(char cont*)

However, the LibreOffice temporary directory, which is the parent of the firebird lockdir, has been deleted by then, which causes the mkdir() to fail, throwing an exception that eventually causes (in development build) firebird to call abort().

So we changed LibreOffice to call fb_shutdown(0, 1) when it does not need firebird anymore, expecting that then ~Cleanup would not be called, or become a noop or ... We checked that fb_shutdown is actually called, and returns success. However, ~Cleanup still tries to do work, for that to create a lockdir, which fails and abort().

Please make fb_shutdown() make all the cleanups so that nothing is done at process exit() time anymore.

 All   Comments   Change History   Subversion Commits      Sort Order: Ascending order - Click to sort in descending order
Alexander Peshkov added a comment - 30/Jun/14 12:10 PM
It's rather problematic to do nothing in ~Cleanup - it's a place in code where dtors of global objects are executed, and this should be done at exit time or when dynamic library is unloaded. Certainly attempts to create files/directories at this moment are absolutely wrong - and this is what I've fixed here.

I do not have access to Mac and therefore to test the fix compiled it on linux using set of system calls used/present on Mac. Everything looks fine but if you have any problems on real build - feel free to contact.

Lionel Elie Mamane added a comment - 30/Jun/14 12:50 PM
Great, thanks. I'm forwarding to one of our Mac guys, and will come back to you with a confirmation.

Lionel Elie Mamane added a comment - 03/Jul/14 03:57 PM
Tested OK on Mac.

Lionel Elie Mamane added a comment - 25/May/16 07:32 AM
In principle, it can be tested:
 * use a _debug_ build of Firebird
 * start a firebird instance, opening a database, do some work
 * call fb_shutdown(0, 1)
 * rm -rf /path/to/fb_lockdir
 * exit(0) the process or unload the firebird dynamic library

If the process aborts, the test failed. If it exits cleanly, the test succeeded.

Dmitry Yemanov added a comment - 25/May/16 08:09 AM
Hard to do with our automated CI framework. We don't test debug builds and we don't test embedded alone. Also, I doubt we can call fb_shutdown() from Python. The comment was about adding a test to the regression suite.