Issue Details (XML | Word | Printable)

Key: CORE-4700
Type: Bug Bug
Status: Closed Closed
Resolution: Fixed
Priority: Trivial Trivial
Assignee: Unassigned
Reporter: Kovalenko Dmitry
Votes: 0
Watchers: 1
Operations

If you were logged in you would be able to see more operations.
Firebird Core

Mistake in GDS_DROP_DATABASE?

Created: 26/Feb/15 07:17 AM   Updated: 23/Sep/15 12:21 PM
Component/s: Engine
Affects Version/s: 2.5.4
Fix Version/s: 2.5.4

QA Status: Cannot be tested


 Description  « Hide
jrd.cpp, GDS_DROP_DATABASE

for (; shadow; shadow = shadow->sdw_next)
{
 err = err || drop_files(shadow->sdw_file); //<---- mistake?
}

I think, this code should be written like this:

for (; shadow; shadow = shadow->sdw_next)
{
 if ( drop_files(shadow->sdw_file) )
  err=true;
}

?



 All   Comments   Change History   Subversion Commits      Sort Order: Ascending order - Click to sort in descending order
Dmitry Yemanov added a comment - 26/Feb/15 09:27 AM
Maybe the idea was to stop dropping shadows after the first failure encountered?

Vlad Khorsun added a comment - 26/Feb/15 09:46 AM
The fix was made in fb3 almost a year ago. Backported.