Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mistake in GDS_DROP_DATABASE? [CORE4700] #5008

Closed
firebird-automations opened this issue Feb 26, 2015 · 6 comments
Closed

Mistake in GDS_DROP_DATABASE? [CORE4700] #5008

firebird-automations opened this issue Feb 26, 2015 · 6 comments

Comments

@firebird-automations
Copy link
Collaborator

Submitted by: @ibprovider

jrd.cpp, GDS_DROP_DATABASE

for (; shadow; shadow = shadow->sdw_next)
{
err = err || drop_files(shadow->sdw_file); //<---- mistake?
}

I think, this code should be written like this:

for (; shadow; shadow = shadow->sdw_next)
{
if ( drop_files(shadow->sdw_file) )
err=true;
}

?

Commits: 395e1aa FirebirdSQL/fbt-repository@ad6e38a

@firebird-automations
Copy link
Collaborator Author

Commented by: @dyemanov

Maybe the idea was to stop dropping shadows after the first failure encountered?

@firebird-automations
Copy link
Collaborator Author

Modified by: @hvlad

priority: Major [ 3 ] => Trivial [ 5 ]

Fix Version: 2.5.4 [ 10585 ]

@firebird-automations
Copy link
Collaborator Author

Commented by: @hvlad

The fix was made in fb3 almost a year ago. Backported.

@firebird-automations
Copy link
Collaborator Author

Modified by: @hvlad

status: Open [ 1 ] => Resolved [ 5 ]

resolution: Fixed [ 1 ]

@firebird-automations
Copy link
Collaborator Author

Modified by: @pavel-zotov

status: Resolved [ 5 ] => Resolved [ 5 ]

QA Status: Cannot be tested

@firebird-automations
Copy link
Collaborator Author

Modified by: @pcisar

status: Resolved [ 5 ] => Closed [ 6 ]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant